From: Jeff King <peff@peff.net>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Makefile: ASCII-sort += lists
Date: Thu, 8 Oct 2020 12:03:50 -0400 [thread overview]
Message-ID: <20201008160350.GB2823778@coredump.intra.peff.net> (raw)
In-Reply-To: <f0f1ef1f677133eabd1bce00c6cdbbcc6477f00b.1602142738.git.liu.denton@gmail.com>
On Thu, Oct 08, 2020 at 12:39:26AM -0700, Denton Liu wrote:
> LIB_H := $(sort $(patsubst ./%,%,$(shell git ls-files '*.h' ':!t/' ':!Documentation/' 2>/dev/null || \
> $(FIND) . \
> @@ -998,9 +998,9 @@ LIB_OBJS += sigchain.o
> LIB_OBJS += split-index.o
> LIB_OBJS += stable-qsort.o
> LIB_OBJS += strbuf.o
> -LIB_OBJS += strvec.o
> LIB_OBJS += streaming.o
> LIB_OBJS += string-list.o
> +LIB_OBJS += strvec.o
> LIB_OBJS += sub-process.o
> LIB_OBJS += submodule-config.o
> LIB_OBJS += submodule.o
> @@ -1066,15 +1066,15 @@ BUILTIN_OBJS += builtin/checkout-index.o
> BUILTIN_OBJS += builtin/checkout.o
> BUILTIN_OBJS += builtin/clean.o
> BUILTIN_OBJS += builtin/clone.o
> -BUILTIN_OBJS += builtin/credential-cache.o
> -BUILTIN_OBJS += builtin/credential-cache--daemon.o
> -BUILTIN_OBJS += builtin/credential-store.o
> BUILTIN_OBJS += builtin/column.o
> BUILTIN_OBJS += builtin/commit-graph.o
> BUILTIN_OBJS += builtin/commit-tree.o
> BUILTIN_OBJS += builtin/commit.o
> BUILTIN_OBJS += builtin/config.o
> BUILTIN_OBJS += builtin/count-objects.o
> +BUILTIN_OBJS += builtin/credential-cache--daemon.o
> +BUILTIN_OBJS += builtin/credential-cache.o
> +BUILTIN_OBJS += builtin/credential-store.o
> BUILTIN_OBJS += builtin/credential.o
> BUILTIN_OBJS += builtin/describe.o
> BUILTIN_OBJS += builtin/diff-files.o
Wow. Both of these hunks are from me, and I clearly _tried_ to put them
in the right place. I think...maybe I'm just bad at alphabetizing?
Curiously, the only subtle part (ascii "-" versus ".") was wrong in the
original spot I moved it from, so I won't blame myself for that. :)
Anyway, the whole patch looks good to me.
-Peff
next prev parent reply other threads:[~2020-10-08 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 7:39 [PATCH] Makefile: ASCII-sort += lists Denton Liu
2020-10-08 10:06 ` Johannes Schindelin
2020-10-08 16:08 ` Jeff King
2020-10-09 10:49 ` Johannes Schindelin
2020-10-09 1:45 ` Denton Liu
2020-10-09 10:51 ` Johannes Schindelin
2020-10-09 16:12 ` Junio C Hamano
2020-10-08 16:03 ` Jeff King [this message]
2020-10-08 17:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008160350.GB2823778@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).