From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t5534: split stdout and stderr redirection
Date: Wed, 7 Oct 2020 07:15:51 +0700 [thread overview]
Message-ID: <20201007001551.GA10178@danh.dev> (raw)
In-Reply-To: <xmqqft6r5fwb.fsf@gitster.c.googlers.com>
On 2020-10-06 12:11:00-0700, Junio C Hamano <gitster@pobox.com> wrote:
> Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
>
> > Arguably, I would say it's OK to change the:
> >
> > test_i18ngrep ! "gpg failed to sign"
> >
> > to:
> >
> > ! grep "gpg failed to sign"
> >
> > since the latter will be correct even if GIT_TEST_GETTEXT_POISON=true
>
> Is it because we haven't managed to translate this particular
> message, or is it because we should never ever translate it perhaps
> because the message is meant for machine consumption?
We translated that message.
> If the latter, yes, I agree with the reasoning,
> but I do not see a reason why this message should never be translated.
I was wrong, I thought test_i18ngrep will blindly "return 0", it does
call grep on "test_i18ngrep !"
Please ignore my non-sense in the foot-note.
I guess the main part is still good, though.
Thanks,
--
Danh
next prev parent reply other threads:[~2020-10-07 0:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 15:08 [PATCH] t5534: split stdout and stderr redirection Đoàn Trần Công Danh
2020-10-06 19:11 ` Junio C Hamano
2020-10-07 0:15 ` Đoàn Trần Công Danh [this message]
2020-10-07 16:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007001551.GA10178@danh.dev \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).