From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 68B631F4B4 for ; Mon, 5 Oct 2020 08:30:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725939AbgJEIaG (ORCPT ); Mon, 5 Oct 2020 04:30:06 -0400 Received: from cloud.peff.net ([104.130.231.41]:49390 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725880AbgJEIaG (ORCPT ); Mon, 5 Oct 2020 04:30:06 -0400 Received: (qmail 31227 invoked by uid 109); 5 Oct 2020 08:30:05 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 05 Oct 2020 08:30:05 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 17345 invoked by uid 111); 5 Oct 2020 08:30:05 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 05 Oct 2020 04:30:05 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 5 Oct 2020 04:30:04 -0400 From: Jeff King To: Jonathan Nieder Cc: git@vger.kernel.org Subject: Re: [PATCH 4/7] t7450: test verify_path() handling of gitmodules Message-ID: <20201005083004.GC2862927@coredump.intra.peff.net> References: <20201005071751.GA2290770@coredump.intra.peff.net> <20201005072015.GD2291074@coredump.intra.peff.net> <20201005075311.GG1166820@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201005075311.GG1166820@google.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Oct 05, 2020 at 12:53:11AM -0700, Jonathan Nieder wrote: > > @@ -155,8 +155,14 @@ test_expect_success 'fsck detects symlinked .gitmodules file' ' > > { > > printf "100644 blob $content\t$tricky\n" && > > printf "120000 blob $target\t.gitmodules\n" > > - } >bad-tree && > > - tree=$(git mktree > + } >bad-tree > > + ) && > > + tree=$(git -C symlink mktree > +' > > This is super nitpicky, but: test scripts can be hard to maintain when > there's this kind of state carried from assertion to assertion without > it being made obvious. > > Can this include "setup" or "set up" in the name to do that? E.g. > > test_expect_success 'set up repo with symlinked .gitmodules file' ' > ... > ' Hmph. I specifically _tried_ to do that by breaking it into a separate test with the name "create" in it, which I thought was one of the code-words for "I'm doing stuff that will be used in another test". But I guess there's no official rule on that. I dug up: https://lore.kernel.org/git/20130826173501.GS4110@google.com/ but I guess I mis-remembered "create" being present there. -Peff