From: Robert Karszniewicz <avoidr@posteo.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-completion.bash: stash-show: add --patch-with-stat
Date: Wed, 30 Sep 2020 23:56:47 +0200 [thread overview]
Message-ID: <20200930215647.GA19843@HP> (raw)
In-Reply-To: <xmqqo8lngjze.fsf@gitster.c.googlers.com>
On Wed, Sep 30, 2020 at 12:09:09PM -0700, Junio C Hamano wrote:
> Robert Karszniewicz <avoidr@posteo.de> writes:
> > So shall I do a v2 as per your suggestion and replace
> > "--patch-with-stat" with "--patch --stat"?
>
> I think Denton Liu offered a different suggestion; I didn't look at
> and compare which direction is the better one myself, but an
> approach that keeps the number of manually-maintained list of
> options low is almost always a good approach.
Ok, I understand, then. Will take a look at it.
Thank you.
prev parent reply other threads:[~2020-09-30 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 11:05 [PATCH] git-completion.bash: stash-show: add --patch-with-stat Robert Karszniewicz
2020-09-28 18:43 ` Junio C Hamano
2020-09-29 6:25 ` Denton Liu
2020-09-29 21:31 ` Robert Karszniewicz
2020-09-30 19:09 ` Junio C Hamano
2020-09-30 21:56 ` Robert Karszniewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930215647.GA19843@HP \
--to=avoidr@posteo.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).