From: Robert Karszniewicz <avoidr@posteo.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-completion.bash: stash-show: add --patch-with-stat
Date: Tue, 29 Sep 2020 23:31:54 +0200 [thread overview]
Message-ID: <20200929213154.GA18321@HP> (raw)
In-Reply-To: <xmqqh7rhn3nk.fsf@gitster.c.googlers.com>
On Mon, Sep 28, 2020 at 11:43:11AM -0700, Junio C Hamano wrote:
> Robert Karszniewicz <avoidr@posteo.de> writes:
>
> > Signed-off-by: Robert Karszniewicz <avoidr@posteo.de>
> > ---
> > contrib/completion/git-completion.bash | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> > index 8be4a0316e..d98c731667 100644
> > --- a/contrib/completion/git-completion.bash
> > +++ b/contrib/completion/git-completion.bash
> > @@ -3016,7 +3016,10 @@ _git_stash ()
> > list,--*)
> > __gitcomp "--name-status --oneline --patch-with-stat"
> > ;;
> > - show,--*|branch,--*)
> > + show,--*)
> > + __gitcomp "--patch-with-stat"
> > + ;;
>
> Why is --patch-with-stat so special?
>
> Without completion support for "--patch" and "--stat", typing
> "--<TAB>" after "git stash show" and seeing only "--patch-with-stat"
> (which has been made obsolete-but-still-kept synonym immediately
> after the other two were invented in 2005) would make a rather
Oh, I didn't know --patch-with-stat was obsoleted. It was recently added
to `stash-list`, too. I can as well use "--patch --stat".
> surprising experience to the end users. For "show" alone, it may
> make a lot of sense to complete "git stash show -<TAB>" and offer
> "-p".
Does git complete short options at all? I only see long options
completed. (I'm also very new to bash-completion)
>
> In any case, it might make more sense to do this instead, and then
> rethink what options make sense to these subcommands of "git stash".
> I do not think patch-with-stat should be among them.
So shall I do a v2 as per your suggestion and replace
"--patch-with-stat" with "--patch --stat"?
>
> - list,--*)
> + list,--* | show,--*)
> __gitcomp "--name-status --oneline --patch-with-stat"
>
> Thanks.
Thank you.
next prev parent reply other threads:[~2020-09-29 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 11:05 [PATCH] git-completion.bash: stash-show: add --patch-with-stat Robert Karszniewicz
2020-09-28 18:43 ` Junio C Hamano
2020-09-29 6:25 ` Denton Liu
2020-09-29 21:31 ` Robert Karszniewicz [this message]
2020-09-30 19:09 ` Junio C Hamano
2020-09-30 21:56 ` Robert Karszniewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929213154.GA18321@HP \
--to=avoidr@posteo.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).