From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 3C6961F4B4 for ; Tue, 29 Sep 2020 00:35:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727048AbgI2AfU (ORCPT ); Mon, 28 Sep 2020 20:35:20 -0400 Received: from cloud.peff.net ([104.130.231.41]:43874 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbgI2AfU (ORCPT ); Mon, 28 Sep 2020 20:35:20 -0400 Received: (qmail 6898 invoked by uid 109); 29 Sep 2020 00:35:20 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 29 Sep 2020 00:35:20 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 13477 invoked by uid 111); 29 Sep 2020 00:35:19 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 28 Sep 2020 20:35:19 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 28 Sep 2020 20:35:19 -0400 From: Jeff King To: Junio C Hamano Cc: Nikita Leonov via GitGitGadget , git@vger.kernel.org, Johannes Schindelin , Nikita Leonov Subject: Re: [PATCH v2 2/3] credentials: make line reading Windows compatible Message-ID: <20200929003519.GB898702@coredump.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Sep 28, 2020 at 01:58:03PM -0700, Junio C Hamano wrote: > "Nikita Leonov via GitGitGadget" writes: > > > From: Nikita Leonov > > > > This commit makes reading process regarding credentials compatible with > > 'CR/LF' line ending. It makes using git more convenient on systems like > > Windows. > > I can see why this is a good thing for "store" and the two updated > pieces of the test script demonstrate it very well. > > But it is unclear why and how cache-daemon benefits from this change. > That needs to be justified. I suspect it doesn't need touched, because it is internal to git-daemon. But it does handle CRLF for some lines, because the first patch modified credential_read(), which the daemon builds on (and which _is_ user-facing via git-credential). So there's perhaps an argument that these calls should just be made consistent, even though the only one who would write them is our matching client. If that is the argument to be made, I think it would make sense to do so in a separate patch, since there's no functional change. (I'm also slightly puzzled that anybody on Windows would care about credential-cache, since it require unix sockets. But maybe in a world of WSL people are actually able to mix the two. I confess I haven't kept up with the state of things in Windows). -Peff