From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id CD1491F4B4 for ; Mon, 28 Sep 2020 03:18:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726465AbgI1DRy (ORCPT ); Sun, 27 Sep 2020 23:17:54 -0400 Received: from cloud.peff.net ([104.130.231.41]:42862 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726442AbgI1DRy (ORCPT ); Sun, 27 Sep 2020 23:17:54 -0400 Received: (qmail 2600 invoked by uid 109); 28 Sep 2020 03:17:54 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 28 Sep 2020 03:17:54 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 3599 invoked by uid 111); 28 Sep 2020 03:17:53 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sun, 27 Sep 2020 23:17:53 -0400 Authentication-Results: peff.net; auth=none Date: Sun, 27 Sep 2020 23:17:52 -0400 From: Jeff King To: Junio C Hamano Cc: git@vger.kernel.org, Eric Sunshine , Martin =?utf-8?B?w4VncmVu?= Subject: Re: [PATCH v2 4/8] shortlog: match commit trailers with --group Message-ID: <20200928031752.GA3059492@coredump.intra.peff.net> References: <20200927083933.GA2222823@coredump.intra.peff.net> <20200927084004.GD2465761@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sun, Sep 27, 2020 at 12:51:43PM -0700, Junio C Hamano wrote: > > +The contents of each trailer value are taken literally and completely. > > +No mailmap is applied, and the `-e` option has no effect (if the trailer > > +contains a username and email, they are both always shown). > > OK. Some users may find that not quite satisfying, though. > > But I have a suspicion that the above will be refined in later > steps? It would have been nicer to see that mentioned in the > proposed log message (e.g. "this step gives the minimum basics and > rough edges like X and Y will be refined with later patches"). I wondered if this might confuse people reading the series, and almost called attention to it in the cover letter. Now that you've presumably read through and figured it out, is it worth going back and amending the commit message? It's more of a point for reviewers, I think, but perhaps somebody reading the commits later would care. -Peff