From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id CF3C21F4B4 for ; Sun, 27 Sep 2020 08:00:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730358AbgI0H73 (ORCPT ); Sun, 27 Sep 2020 03:59:29 -0400 Received: from cloud.peff.net ([104.130.231.41]:42300 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726382AbgI0H73 (ORCPT ); Sun, 27 Sep 2020 03:59:29 -0400 Received: (qmail 28549 invoked by uid 109); 27 Sep 2020 07:59:28 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sun, 27 Sep 2020 07:59:28 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 3759 invoked by uid 111); 27 Sep 2020 07:59:30 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sun, 27 Sep 2020 03:59:30 -0400 Authentication-Results: peff.net; auth=none Date: Sun, 27 Sep 2020 03:59:27 -0400 From: Jeff King To: Martin =?utf-8?B?w4VncmVu?= Cc: Git Mailing List Subject: Re: [PATCH 2/8] shortlog: refactor committer/author grouping Message-ID: <20200927075927.GA1286220@coredump.intra.peff.net> References: <20200925070120.GA3669667@coredump.intra.peff.net> <20200925070211.GB62741@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Sep 26, 2020 at 02:31:32PM +0200, Martin Ågren wrote: > On Fri, 25 Sep 2020 at 09:04, Jeff King wrote: > > > > In preparation for adding more grouping types, let's > > refactor the committer/author grouping code. In particular: > > > > - the master option is now "--group", to make it clear > > that the various group types are mutually exclusive. The > > "--committer" option is an alias for "--group=committer". > > I think this is more than a refactoring of the code. The user interface > is also refactored (if that's even the right word). From the subject and > the first sentence above, I did not expect this first "-" item, nor that > the patch would touch Documentation/. Yeah, I agree it's a bit misleading. I've reworded it (especially the title) to make the intent more clear. > > + enum { > > + SHORTLOG_GROUP_AUTHOR = 0, > > + SHORTLOG_GROUP_COMMITTER > > + } group; > > You could reduce the patch noise by adding a trailing comma, see > cc0c42975a ("CodingGuidelines: spell out post-C89 rules", 2019-07-16). > (I do realize that you later redefine all values anyway.) Thanks, that's worth doing. This part of the series was actually from 2015, so perhaps before we had that guideline. :) -Peff