From: Jeff King <peff@peff.net>
To: phillip.wood@dunelm.org.uk
Cc: Ryan Zoeller <rtzoeller@rtzoeller.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [RFC 0/1] Leading whitespace as a function identification heuristic?
Date: Fri, 25 Sep 2020 15:05:01 -0400 [thread overview]
Message-ID: <20200925190501.GA668512@coredump.intra.peff.net> (raw)
In-Reply-To: <005de229-ad05-437c-7b83-8f6502b4e27d@gmail.com>
On Fri, Sep 25, 2020 at 08:01:07PM +0100, Phillip Wood wrote:
> > Another possible corner case: tabs vs spaces. If I have:
> >
> > <space><space><space><space><space><space><space><space>foo
> > <tab><tab>bar
> >
> > which is more indented? Counting isspace(), it is the first one. But
> > visually, it would _usually_ be the second one. But of course it would
> > depend on your tabstops.
> >
> > The above example is obviously stupid and contrived, but I wonder if
> > there are legitimate confusing cases where people mix tabs and spaces
> > (e.g., mixed tabs and spaces to align function parameters, etc).
>
> To calculate the indentation for diff
> --color-moved-ws=allow-indentation-change in fill_es_indent_data() we use
> the tabwidth whitespace attribute to calculate the width of a tab in spaces
> [...]
Ah, right, I forgot we already had "tabwidth" config to deal with this.
I agree we could make use of that same technique here.
-Peff
next prev parent reply other threads:[~2020-09-25 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 21:59 [RFC 0/1] Leading whitespace as a function identification heuristic? Ryan Zoeller
2020-09-23 21:59 ` [RFC 1/1] xdiff: use leading whitespace in function heuristic Ryan Zoeller
2020-09-24 6:45 ` [RFC 0/1] Leading whitespace as a function identification heuristic? Junio C Hamano
2020-09-24 21:17 ` Jeff King
2020-09-24 22:01 ` Ryan Zoeller
2020-09-25 9:11 ` Phillip Wood
2020-09-25 18:43 ` Jeff King
2020-09-25 19:01 ` Phillip Wood
2020-09-25 19:05 ` Jeff King [this message]
2020-09-25 18:12 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925190501.GA668512@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=rtzoeller@rtzoeller.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).