From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 0/4] Clean-up around get_x_ish()
Date: Thu, 24 Sep 2020 22:59:50 -0700 [thread overview]
Message-ID: <20200925055954.1111389-1-gitster@pobox.com> (raw)
Here is to clean some code I noticed while auditing the use of
get_committish() and get_treeish() API functions.
The main topic is to tighten error checking of "blame --ignore-rev"
and "blame --ignore-revs-list" arguments, which were not checked all
that much. We make sure the ignore revs are committish objects, and
also peel tags pointing at commits down to commits before using them.
The breakage in the original is demonstrated by the tests added and/or
tweaked in the second patch.
The last two patches are icing on the cake.
Junio C Hamano (4):
t8013: minimum preparatory clean-up
blame: validate and peel the object names on the ignore list
t1506: rev-parse A..B and A...B
sequencer: stop abbreviating stopped-sha file
builtin/blame.c | 27 +++++++++++++--
oidset.c | 9 ++++-
oidset.h | 9 +++++
sequencer.c | 11 +++---
t/t1506-rev-parse-diagnosis.sh | 18 ++++++++++
t/t8013-blame-ignore-revs.sh | 61 ++++++++++++++++++++++------------
6 files changed, 105 insertions(+), 30 deletions(-)
--
2.28.0-718-gd8d5e3da39
next reply other threads:[~2020-09-25 6:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 5:59 Junio C Hamano [this message]
2020-09-25 5:59 ` [PATCH 1/4] t8013: minimum preparatory clean-up Junio C Hamano
2020-09-25 5:59 ` [PATCH 2/4] blame: validate and peel the object names on the ignore list Junio C Hamano
2020-09-26 16:23 ` René Scharfe
2020-09-26 17:06 ` Junio C Hamano
2020-09-26 23:58 ` Junio C Hamano
2020-09-28 13:26 ` Barret Rhoden
2020-10-11 16:03 ` René Scharfe
2020-10-12 16:54 ` Junio C Hamano
2020-10-12 20:39 ` Barret Rhoden
2020-10-13 20:12 ` René Scharfe
2020-09-25 5:59 ` [PATCH 3/4] t1506: rev-parse A..B and A...B Junio C Hamano
2020-09-25 5:59 ` [PATCH 4/4] sequencer: stop abbreviating stopped-sha file Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925055954.1111389-1-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).