From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Han-Wen Nienhuys <hanwen@google.com>, git <git@vger.kernel.org>,
Han-Wen Nienhuys <hanwenn@gmail.com>
Subject: [PATCH 0/2] drop unaligned loads
Date: Thu, 24 Sep 2020 15:16:38 -0400 [thread overview]
Message-ID: <20200924191638.GA2528003@coredump.intra.peff.net> (raw)
On Thu, Sep 24, 2020 at 10:22:20AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Then I did the same, but building with -DNO_UNALIGNED_LOADS. The latter
> > actually ran faster, by a small margin. Here are the hyperfine results:
> >
> > [stock]
> > Time (mean ± σ): 6.638 s ± 0.081 s [User: 6.269 s, System: 0.368 s]
> > Range (min … max): 6.550 s … 6.841 s 10 runs
> >
> > [-DNO_UNALIGNED_LOADS]
> > Time (mean ± σ): 6.418 s ± 0.015 s [User: 6.058 s, System: 0.360 s]
> > Range (min … max): 6.394 s … 6.447 s 10 runs
> >
> > For casual use as in reftables I doubt the difference is even
> > measurable. But this result implies that perhaps we ought to just be
> > using the fallback version all the time.
>
> I like that one. One less configurable knob that makes us execute
> different codepaths is one less thing to be worried about.
Here it is with a little more research, then, and a cleanup we can do on
top.
[1/2]: bswap.h: drop unaligned loads
[2/2]: Revert "fast-export: use local array to store anonymized oid"
Makefile | 1 -
builtin/fast-export.c | 8 ++++----
compat/bswap.h | 24 ------------------------
3 files changed, 4 insertions(+), 29 deletions(-)
-Peff
next reply other threads:[~2020-09-24 19:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 19:16 Jeff King [this message]
2020-09-24 19:21 ` [PATCH 1/2] bswap.h: drop unaligned loads Jeff King
2020-09-24 22:02 ` René Scharfe
2020-09-25 4:56 ` Jeff King
2020-09-25 1:13 ` brian m. carlson
2020-09-25 9:05 ` Carlo Arenas
2020-09-25 9:09 ` Jeff King
2020-09-25 20:48 ` Thomas Guyot
2020-09-24 19:22 ` [PATCH 2/2] Revert "fast-export: use local array to store anonymized oid" Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924191638.GA2528003@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
--cc=hanwenn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).