From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id EACB61F4B4 for ; Thu, 24 Sep 2020 06:38:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726959AbgIXGib (ORCPT ); Thu, 24 Sep 2020 02:38:31 -0400 Received: from cloud.peff.net ([104.130.231.41]:38998 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbgIXGib (ORCPT ); Thu, 24 Sep 2020 02:38:31 -0400 Received: (qmail 1490 invoked by uid 109); 24 Sep 2020 06:38:30 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 24 Sep 2020 06:38:30 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 18300 invoked by uid 111); 24 Sep 2020 06:38:32 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 24 Sep 2020 02:38:32 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 24 Sep 2020 02:38:29 -0400 From: Jeff King To: Ilan Biala Cc: git@vger.kernel.org Subject: Re: git diff --name-only --submodule=diff combination does not work Message-ID: <20200924063829.GA1851751@coredump.intra.peff.net> References: <20200922193407.23931C0613CF@lindbergh.monkeyblade.net> <20200922212404.GA547416@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Sep 22, 2020 at 05:32:12PM -0400, Ilan Biala wrote: > I expected adding --submodule=diff to add all the filenames in > submodules that were modified, but the output just shows the submodule > folder name, not all the files within the submodule that were > modified. OK. That does sound like a useful thing to show, but AFAIK there is not currently a way to do so. Formats like --name-only and --raw are capable of showing a diff for the submodule entry itself, so they do. And we'd want to continue to be able to do that even when the diff.submodule config option is set. So I suspect it would need to be something like --submodule=name-only. I.e., allowing any diff format to be passed there. -Peff