From: Jeff King <peff@peff.net>
To: Ilan Biala <ilanbiala@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git diff --name-only --submodule=diff combination does not work
Date: Thu, 24 Sep 2020 02:38:29 -0400 [thread overview]
Message-ID: <20200924063829.GA1851751@coredump.intra.peff.net> (raw)
In-Reply-To: <CAD2jYq8OtHUpfUZyXC_+FHew45XEtgty3H-XF_2e30mb6kCCmw@mail.gmail.com>
On Tue, Sep 22, 2020 at 05:32:12PM -0400, Ilan Biala wrote:
> I expected adding --submodule=diff to add all the filenames in
> submodules that were modified, but the output just shows the submodule
> folder name, not all the files within the submodule that were
> modified.
OK. That does sound like a useful thing to show, but AFAIK there is not
currently a way to do so. Formats like --name-only and --raw are capable
of showing a diff for the submodule entry itself, so they do. And we'd
want to continue to be able to do that even when the diff.submodule
config option is set. So I suspect it would need to be something like
--submodule=name-only. I.e., allowing any diff format to be passed
there.
-Peff
prev parent reply other threads:[~2020-09-24 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200922193407.23931C0613CF@lindbergh.monkeyblade.net>
2020-09-22 20:56 ` git diff --name-only --submodule=diff combination does not work Ilan Biala
2020-09-22 21:24 ` Jeff King
2020-09-22 21:32 ` Ilan Biala
2020-09-24 6:38 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924063829.GA1851751@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=ilanbiala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).