From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 3A40F1F4B4 for ; Wed, 16 Sep 2020 18:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728178AbgIPStP (ORCPT ); Wed, 16 Sep 2020 14:49:15 -0400 Received: from cloud.peff.net ([104.130.231.41]:58732 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727936AbgIPStK (ORCPT ); Wed, 16 Sep 2020 14:49:10 -0400 Received: (qmail 25820 invoked by uid 109); 16 Sep 2020 18:49:09 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 16 Sep 2020 18:49:09 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 31256 invoked by uid 111); 16 Sep 2020 18:49:09 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 16 Sep 2020 14:49:09 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 16 Sep 2020 14:49:08 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Matthieu Moy , Johannes Schindelin , Antoine =?utf-8?Q?Beaupr=C3=A9?= , Simon Legner Subject: Re: [PATCH 11/15] remote-mediawiki tests: replace deprecated Perl construct Message-ID: <20200916184908.GD33925@coredump.intra.peff.net> References: <20200916102918.29805-1-avarab@gmail.com> <20200916102918.29805-12-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200916102918.29805-12-avarab@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Sep 16, 2020 at 12:29:14PM +0200, Ævar Arnfjörð Bjarmason wrote: > The use of the encoding pragma has been a hard error since Perl 5.18, > which was released in 2013. What this script really wanted to do was > to decode @ARGV and write out some files with the UTF-8 PerlIO > layer. Let's just do that explicitly instead. Makes sense. After reading this, I expected the utf::decode() for argv you added, but wondered about the UTF-8 output. But I think the "use open ':encoding(utf8)'" below takes care of that. -Peff