From: Taylor Blau <firstname.lastname@example.org> To: Junio C Hamano <email@example.com> Cc: "Jakub Narębski" <firstname.lastname@example.org>, git <email@example.com>, "Abhishek Kumar" <firstname.lastname@example.org>, "Derrick Stolee" <email@example.com>, "Taylor Blau" <firstname.lastname@example.org> Subject: Re: What's cooking in git.git (Sep 2020, #03; Wed, 9) Date: Tue, 15 Sep 2020 17:48:02 -0400 [thread overview] Message-ID: <20200915214802.GB1741@nand.local> (raw) In-Reply-To: <email@example.com> On Tue, Sep 15, 2020 at 02:45:51PM -0700, Junio C Hamano wrote: > Jakub Narębski <firstname.lastname@example.org> writes: > > > >> My gut feeling is that overflow handling needs to be there whether the > >> field is 32-bit or 64-bit. > > > > Not if the size on-disk is the same as the size in memory: > > timestamp_t is usually 64 bit (and even unsigned 64 bit epoch > > would be enough - its range is over twenty times the present > > age of the universe per direction). > > Yes, and "corrected commit dates" is about accommodating commits > with absurd out-of-sync timestamp mixed in a history with commits > with correct timestamp, right? What happens if the absurd timestamp > is near the limit of the range? You do not have to live through the > end of the universe---you only have to create a commit object that > records such a timestamp, no? I completely agree with Junio's sentiment here. The overflow handling needs to exist no matter what, but let's remember what's common and what isn't. Since it's not common to be towards the end of even just the 32-bit range, let's "optimize" for that and store the fields as 32 bits wide. Thanks, Taylor
next prev parent reply other threads:[~2020-09-15 21:49 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-09 22:32 Junio C Hamano 2020-09-09 23:07 ` Eric Sunshine 2020-09-10 4:52 ` Junio C Hamano 2020-09-15 22:48 ` Eric Sunshine 2020-09-15 22:54 ` Junio C Hamano 2020-09-15 19:05 ` Jakub Narębski 2020-09-15 19:32 ` Taylor Blau 2020-09-15 21:14 ` Junio C Hamano 2020-09-15 21:25 ` Jakub Narębski 2020-09-15 21:45 ` Junio C Hamano 2020-09-15 21:48 ` Taylor Blau [this message] 2020-09-15 22:32 ` Junio C Hamano 2020-09-15 22:02 ` Jakub Narębski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200915214802.GB1741@nand.local \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: What'\''s cooking in git.git (Sep 2020, #03; Wed, 9)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).