From: Rafael Silva <rafaeloliveira.cs@gmail.com>
To: git@vger.kernel.org
Cc: dstolee@microsoft.com, gitster@pobox.com
Subject: bug found on the new git maintenance builtin command
Date: Mon, 14 Sep 2020 19:49:38 +0000 [thread overview]
Message-ID: <20200914194938.GA4235@contrib-buster.localdomain> (raw)
Hi Everyone,
I found a minor bug when testing the new maintenance built-in command that was
introduced on 679768e2a1 (maintenance: create basic maintenance runner, 2020-08-25) submitted in [1]
When running `git maintenance` without argument it receives
a segmentation fault. I'm running git built on the current `seen` branch that is pointing
to bf3e2864f3 (Merge branch 'ds/maintenance-part-3' into seen, 2020-09-11)
I did a little investigation and it seems the command needs to check when no arguments
are passed to the cmd_maintanance() function and either quit with usage or redirect to man.
To reproduce the error, just run the `git maintenance` without any arguments
$ git maintenance
Segmentation fault
Analysign with GDB right before the SEGFAULT are thrown, we can see
the argv[1] pointing to NULL as follows:
(gdb) list
1628 int cmd_maintenance(int argc, const char **argv, const char *prefix)
1629 {
1630 if (argc == 2 && !strcmp(argv[1], "-h"))
1631 usage(builtin_maintenance_usage);
1632
1633 fprintf(stdout, "run");
1634 if (!strcmp(argv[1], "run"))
1635 return maintenance_run(argc - 1, argv + 1, prefix);
1636 if (!strcmp(argv[1], "start"))
1637 return maintenance_start();
(gdb) print argc
$5 = 1
(gdb) print argv[1]
$6 = 0x0
Hope all this information helps with the fixing it
[1] Patch submission can be found in:
https://public-inbox.org/git/aa961af387b7f458f75ad60b9a2a45da4bb43794.1599224956.git.gitgitgadget@gmail.com/
Regards,
Rafael Silva
next reply other threads:[~2020-09-14 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 19:49 Rafael Silva [this message]
2020-09-14 20:48 ` bug found on the new git maintenance builtin command Derrick Stolee
2020-09-14 20:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914194938.GA4235@contrib-buster.localdomain \
--to=rafaeloliveira.cs@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).