From: "brian m. carlson" <firstname.lastname@example.org> To: "Martin Ågren" <email@example.com> Cc: Git Mailing List <firstname.lastname@example.org> Subject: Re: [PATCH 1/3] docs: explain why squash merges are broken with long-running branches Date: Sun, 13 Sep 2020 17:12:06 +0000 [thread overview] Message-ID: <20200913171206.GO241078@camp.crustytoothpaste.net> (raw) In-Reply-To: <CAN0heSo8XsToRm1st4PqPp8PNwc98Csx-+o78J-mh3bbYoneWQ@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 2075 bytes --] On 2020-09-13 at 15:05:31, Martin Ågren wrote: > On Sat, 12 Sep 2020 at 22:52, brian m. carlson > <email@example.com> wrote: > > > > In many projects, squash merges are commonly used, primarily to keep a > > tidy history in the face of developers who do not use logically > > independent, bisectable commits. As common as this is, this tends to > > cause significant problems when squash merges are used to merge > > long-running branches due to the lack of any new merge bases. Even very > > experienced developers may make this mistakes, so let's add a FAQ entry > > s/mistakes/mistake/ Will fix. > Very well-written, as always. > > I grepped around a little and couldn't find that we're using this "long- > running branch" notion anywhere. I think it might make sense to > define/explain that somewhere early, e.g., with something like "... > merged repeatedly ... more development...". > > So in particular, a "long-running" branch is not something like > > I branched off a long time ago, I've been hacking on this feature for > a long time and the branch has run quite long with lots of commits. > Now it's time to merge it and be done with it! Correct. By "long-running branch", I mean a branch into which code routinely gets integrated from feature branches. For example, the branches master and develop in a Git Flow workflow, or per-version release branches if you use that workflow. I didn't mean an otherwise divergent branch which has persisted for a long time. The problem happens, essentially, if you have two branches and you merge one of them into another repeatedly with squash merges, so I'll be sure to make that clear. That will probably help with intelligibility for non-native speakers as well. > Once that piece of background is in place, what you have here reads very > well to me. It was only somewhere halfway through the second paragraph > that I got what you meant by "long-running branch". Thanks, this is helpful feedback. -- brian m. carlson: Houston, Texas, US [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2020-09-13 17:12 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-12 20:48 [PATCH 0/3] FAQ entries for merges and modified files brian m. carlson 2020-09-12 20:48 ` [PATCH 1/3] docs: explain why squash merges are broken with long-running branches brian m. carlson 2020-09-13 15:05 ` Martin Ågren 2020-09-13 17:12 ` brian m. carlson [this message] 2020-09-12 20:48 ` [PATCH 2/3] docs: explain why reverts are not always applied on merge brian m. carlson 2020-09-13 15:12 ` Martin Ågren 2020-09-12 20:48 ` [PATCH 3/3] docs: explain how to deal with files that are always modified brian m. carlson 2020-09-13 15:13 ` Martin Ågren 2020-09-12 21:48 ` [PATCH 0/3] FAQ entries for merges and modified files Junio C Hamano 2020-09-20 23:22 ` [PATCH v2 " brian m. carlson 2020-09-20 23:22 ` [PATCH v2 1/3] docs: explain why squash merges are broken with long-running branches brian m. carlson 2020-09-20 23:22 ` [PATCH v2 2/3] docs: explain why reverts are not always applied on merge brian m. carlson 2020-09-20 23:22 ` [PATCH v2 3/3] docs: explain how to deal with files that are always modified brian m. carlson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200913171206.GO241078@camp.crustytoothpaste.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 1/3] docs: explain why squash merges are broken with long-running branches' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).