From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Edmundo Carmona Antoranz <eantoranz@gmail.com>,
Derrick Stolee <stolee@gmail.com>,
whydoubt@gmail.com, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] blame.c: replace instance of !oidcmp for oideq
Date: Wed, 9 Sep 2020 15:58:03 -0400 [thread overview]
Message-ID: <20200909195803.GA2515827@coredump.intra.peff.net> (raw)
In-Reply-To: <0773b560-b456-fc88-42d7-f214246ddd1b@web.de>
On Wed, Sep 09, 2020 at 09:54:55PM +0200, René Scharfe wrote:
> > diff -u -p a/packfile.c b/packfile.c
> > --- a/packfile.c
> > +++ b/packfile.c
> > @@ -735,7 +735,7 @@ struct packed_git *add_packed_git(const
> > p->mtime = st.st_mtime;
> > if (path_len < the_hash_algo->hexsz ||
> > get_sha1_hex(path + path_len - the_hash_algo->hexsz, p->hash))
> > - hashclr(p->hash);
> > + oidclr(p);
> > return p;
> > }
> >
> >
> > Maybe it's worth being looser in our cocci patch definitions. I'm having
> > trouble thinking of a downside...
>
> For transformations that change the type as in the example above we
> should insist on getting the right one, otherwise we might introduce
> bugs -- like in the example above. p points to a struct packed_git and
> not to a struct object_id, so this introduces a type mismatch.
Heh. You'd think that I would have applied that patch and run "make". Or
even read it carefully.
Thanks for pointing that out. I guess now we have a real example of a
downside (the compiler _would_ still catch it, but it means "make
coccicheck" is useless if it's repeatedly suggesting a bad
transformation).
-Peff
next prev parent reply other threads:[~2020-09-09 19:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 17:16 [PATCH] blame.c: replace instance of !oidcmp for oideq Edmundo Carmona Antoranz
2020-09-07 17:21 ` Edmundo Carmona Antoranz
2020-09-08 13:55 ` Edmundo Carmona Antoranz
2020-09-08 19:07 ` Derrick Stolee
2020-09-09 9:11 ` Jeff King
2020-09-09 14:00 ` Edmundo Carmona Antoranz
2020-09-09 17:48 ` Jeff Smith
2020-09-09 19:13 ` Jeff King
2020-09-09 19:17 ` Jeff King
2020-09-09 19:54 ` René Scharfe
2020-09-09 19:58 ` Jeff King [this message]
2020-09-09 20:03 ` Junio C Hamano
2020-09-09 20:06 ` Junio C Hamano
2020-09-09 20:43 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909195803.GA2515827@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=eantoranz@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=stolee@gmail.com \
--cc=whydoubt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).