From: Jeff King <peff@peff.net>
To: Derrick Stolee <stolee@gmail.com>
Cc: "René Scharfe" <l.s.r@web.de>,
"Edmundo Carmona Antoranz" <eantoranz@gmail.com>,
whydoubt@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] blame.c: replace instance of !oidcmp for oideq
Date: Wed, 9 Sep 2020 05:11:49 -0400 [thread overview]
Message-ID: <20200909091149.GB2496536@coredump.intra.peff.net> (raw)
In-Reply-To: <ce94b41f-e829-d7ca-a5f5-e41748caea81@gmail.com>
On Tue, Sep 08, 2020 at 03:07:34PM -0400, Derrick Stolee wrote:
> This message could also mention 14438c4 (introduce hasheq() and
> oideq(), 2018-08-28) which introduced oideq().
>
> This use of !oidcmp() was introduced by 0906ac2b (blame: use
> changed-path Bloom filters, 2020-04-16). My bad. There is no
> good reason to introduce this use since it is well after the
> oideq() method was introduced.
>
> > @@ -1353,8 +1353,8 @@ static struct blame_origin *find_origin(struct repository *r,
> > else {
> > int compute_diff = 1;
> > if (origin->commit->parents &&
> > - !oidcmp(&parent->object.oid,
> > - &origin->commit->parents->item->object.oid))
> > + oideq(&parent->object.oid,
> > + &origin->commit->parents->item->object.oid))
> > compute_diff = maybe_changed_path(r, origin, bd);
>
> The code itself looks correct.
Yeah, it looks obviously correct. I am puzzled why "make coccicheck"
doesn't find this, though. +cc René, as my favorite target for
coccinelle nerd-snipes. :)
(But clearly we should make the change with or without figuring out the
coccinelle part).
-Peff
next prev parent reply other threads:[~2020-09-09 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 17:16 [PATCH] blame.c: replace instance of !oidcmp for oideq Edmundo Carmona Antoranz
2020-09-07 17:21 ` Edmundo Carmona Antoranz
2020-09-08 13:55 ` Edmundo Carmona Antoranz
2020-09-08 19:07 ` Derrick Stolee
2020-09-09 9:11 ` Jeff King [this message]
2020-09-09 14:00 ` Edmundo Carmona Antoranz
2020-09-09 17:48 ` Jeff Smith
2020-09-09 19:13 ` Jeff King
2020-09-09 19:17 ` Jeff King
2020-09-09 19:54 ` René Scharfe
2020-09-09 19:58 ` Jeff King
2020-09-09 20:03 ` Junio C Hamano
2020-09-09 20:06 ` Junio C Hamano
2020-09-09 20:43 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909091149.GB2496536@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=eantoranz@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=stolee@gmail.com \
--cc=whydoubt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).