From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
To: dstolee@microsoft.com, git@vger.kernel.org, peff@peff.net
Cc: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Subject: [PATCH v2] blame.c: replace instance of !oidcmp for oideq
Date: Tue, 8 Sep 2020 15:10:53 -0600 [thread overview]
Message-ID: <20200908211053.807194-1-eantoranz@gmail.com> (raw)
0906ac2b54b introduced a call to oidcmp() that should be
replaced by oideq() (the latter introduced in 14438c4).
Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
---
blame.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/blame.c b/blame.c
index da7e28800e..a8abe86ae4 100644
--- a/blame.c
+++ b/blame.c
@@ -1352,8 +1352,8 @@ static struct blame_origin *find_origin(struct repository *r,
else {
int compute_diff = 1;
if (origin->commit->parents &&
- !oidcmp(&parent->object.oid,
- &origin->commit->parents->item->object.oid))
+ oideq(&parent->object.oid,
+ &origin->commit->parents->item->object.oid))
compute_diff = maybe_changed_path(r, origin, bd);
if (compute_diff)
--
2.28.0
next reply other threads:[~2020-09-08 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 21:10 Edmundo Carmona Antoranz [this message]
2020-09-09 12:39 ` [PATCH v2] blame.c: replace instance of !oidcmp for oideq Derrick Stolee
2020-09-09 13:10 ` Edmundo Carmona Antoranz
2020-09-09 18:35 ` Junio C Hamano
2020-09-09 19:13 ` Edmundo Carmona Antoranz
2020-09-09 20:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908211053.807194-1-eantoranz@gmail.com \
--to=eantoranz@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).