From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 8C8741F66E for ; Mon, 7 Sep 2020 08:07:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727935AbgIGIHT (ORCPT ); Mon, 7 Sep 2020 04:07:19 -0400 Received: from cloud.peff.net ([104.130.231.41]:50240 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727953AbgIGIHJ (ORCPT ); Mon, 7 Sep 2020 04:07:09 -0400 Received: (qmail 12554 invoked by uid 109); 7 Sep 2020 08:06:33 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 07 Sep 2020 08:06:33 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 14337 invoked by uid 111); 7 Sep 2020 08:06:35 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 07 Sep 2020 04:06:35 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 7 Sep 2020 04:06:32 -0400 From: Jeff King To: git@vger.kernel.org Cc: Tom Hale , Johannes Schindelin Subject: [PATCH 0/2] some minor add--interactive fixes Message-ID: <20200907080632.GA1261825@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org There was a mini-mystery about the add--interactive tests on the git-mentoring list this morning. The second patch here solves the mystery. But while digging I also noticed a bug in the new C version, which is fixed by the first patch. [1/2]: add-patch: fix inverted return code of repo_read_index() [2/2]: add--interactive.perl: specify --no-color explicitly add-patch.c | 2 +- git-add--interactive.perl | 2 +- t/t3701-add-interactive.sh | 8 ++++++++ 3 files changed, 10 insertions(+), 2 deletions(-) -Peff