git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>, Taylor Blau <me@ttaylorr.com>,
	Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH] midx: use hashwrite_u8() in write_midx_header()
Date: Sun, 6 Sep 2020 15:03:40 -0400	[thread overview]
Message-ID: <20200906190340.GB6146@nand.local> (raw)
In-Reply-To: <ae03833d-d597-f902-38d5-9e67bd768d93@web.de>

On Sun, Sep 06, 2020 at 10:59:02AM +0200, René Scharfe wrote:
> Emit byte-sized values using hashwrite_u8() instead of buffering them
> locally first.  The hashwrite functions already do their own buffering,
> so this double-buffering does not reduce the number of system calls.
> Getting rid of it shortens and simplifies the code a bit.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>

Looks great.

  Acked-by: Taylor Blau <me@ttaylorr.com>

Thanks,
Taylor

      reply	other threads:[~2020-09-06 19:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06  8:59 [PATCH] midx: use hashwrite_u8() in write_midx_header() René Scharfe
2020-09-06 19:03 ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200906190340.GB6146@nand.local \
    --to=me@ttaylorr.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=l.s.r@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).