From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jonathan Tan <jonathantanmy@google.com>,
gitgitgadget@gmail.com, git@vger.kernel.org, hanwenn@gmail.com,
hanwen@google.com, git@jeffhostetler.com, stolee@gmail.com,
Josh Steadmon <steadmon@google.com>
Subject: Re: [PATCH] RFC: refs: add GIT_DEBUG_REFS debugging mechanism
Date: Thu, 3 Sep 2020 02:19:31 -0400 [thread overview]
Message-ID: <20200903061931.GA2055118@coredump.intra.peff.net> (raw)
In-Reply-To: <20200903054422.GG4035286@google.com>
On Wed, Sep 02, 2020 at 10:44:22PM -0700, Jonathan Nieder wrote:
> Summary:
>
> - if this is only going to be used for tests and for ad hoc debugging,
> I'd suggest sticking to the simple trace_key based unstructured
> tracing API
Yeah, from my look at the debug patch, this seems sensible.
As clever as the "debug" ref-backend wrapper object is, I also wonder if
it might be simpler to just add trace calls to all of the outer
functions (e.g., ref_transaction_prepare(), etc). Unlike a "real" OO
system, we're not typically passing around the polymorphic ref_store
type, but always access it through those type-agnostic wrappers. But
maybe that would end up just as long. I dunno.
-Peff
next prev parent reply other threads:[~2020-09-03 6:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 15:28 [PATCH] RFC: refs: add GIT_DEBUG_REFS debugging mechanism Han-Wen Nienhuys via GitGitGadget
2020-09-02 17:49 ` Jonathan Tan
2020-09-03 5:44 ` Jonathan Nieder
2020-09-03 6:19 ` Jeff King [this message]
[not found] ` <CAFQ2z_M_2mmL1LXcgR5cv3Ac1AJ363jaejZz3p6AcV6b3DftTQ@mail.gmail.com>
2020-09-03 10:10 ` Fwd: " Han-Wen Nienhuys
2020-09-07 15:24 ` [PATCH v2] refs: add GIT_TRACE_REFS " Han-Wen Nienhuys via GitGitGadget
2020-09-08 21:15 ` Junio C Hamano
2020-09-09 9:43 ` Han-Wen Nienhuys
2020-09-09 10:15 ` [PATCH v3] " Han-Wen Nienhuys via GitGitGadget
2020-09-16 15:53 ` [PATCH v4] " Han-Wen Nienhuys via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903061931.GA2055118@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hanwen@google.com \
--cc=hanwenn@gmail.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=steadmon@google.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).