From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Derrick Stolee <stolee@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] xrealloc: do not reuse pointer freed by zero-length realloc()
Date: Wed, 2 Sep 2020 20:50:08 -0700 [thread overview]
Message-ID: <20200903035008.GF4035286@google.com> (raw)
In-Reply-To: <xmqq3641ebep.fsf@gitster.c.googlers.com>
Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>> If we do handle it up-front, then I think we'd actually want:
>>
>> if (!size) {
>> free(ptr);
>> return xmalloc(0);
>> }
>>
>> (i.e., to never return NULL for consistency with xmalloc() and
>> xcalloc()).
>
> Makes sense. I suspect that this is optimizing for a wrong case,
> but in practice that should not matter. Not having to worry about
> a request to resize to 0-byte in the remainder of the function is
> actually a plus for readability, I would say.
I agree with both points: if we were repeatedly shrinking and growing
a buffer and cared about its performance, then we'd want the first
version, and since we aren't, we should prefer this version that is
more readable.
Thanks,
Jonathan
next prev parent reply other threads:[~2020-09-03 3:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 11:18 [PATCH] xrealloc: do not reuse pointer freed by zero-length realloc() Jeff King
2020-09-01 13:04 ` Derrick Stolee
2020-09-01 13:51 ` Jeff King
2020-09-01 14:24 ` Derrick Stolee
2020-09-01 15:58 ` Junio C Hamano
2020-09-02 7:54 ` Jeff King
2020-09-02 19:19 ` Junio C Hamano
2020-09-03 3:50 ` Jonathan Nieder [this message]
2020-09-01 15:20 ` Andreas Schwab
2020-09-01 15:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903035008.GF4035286@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).