From: Miriam Rubio <mirucam@gmail.com>
To: git@vger.kernel.org
Cc: Miriam Rubio <mirucam@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v6 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return
Date: Fri, 28 Aug 2020 14:46:06 +0200 [thread overview]
Message-ID: <20200828124617.60618-3-mirucam@gmail.com> (raw)
In-Reply-To: <20200828124617.60618-1-mirucam@gmail.com>
Following 'enum bisect_error' vocabulary, return variable 'res' is
always non-positive.
Let's use '-res' instead of 'abs(res)' to make the code clearer.
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
---
builtin/bisect--helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index f464e95792..b7345be3a5 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -731,5 +731,5 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
if (res == BISECT_INTERNAL_SUCCESS_MERGE_BASE)
res = BISECT_OK;
- return abs(res);
+ return -res;
}
--
2.25.0
next prev parent reply other threads:[~2020-08-28 12:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 12:46 [PATCH v6 00/13] Finish converting git bisect to C part 2 Miriam Rubio
2020-08-28 12:46 ` [PATCH v6 01/13] bisect--helper: BUG() in cmd_*() on invalid subcommand Miriam Rubio
2020-08-28 12:46 ` Miriam Rubio [this message]
2020-08-28 12:46 ` [PATCH v6 03/13] bisect--helper: introduce new `write_in_file()` function Miriam Rubio
2020-08-28 12:46 ` [PATCH v6 04/13] bisect--helper: reimplement `bisect_autostart` shell function in C Miriam Rubio
2020-08-28 12:46 ` [PATCH v6 05/13] bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()' Miriam Rubio
2020-08-28 12:46 ` [PATCH v6 06/13] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in C Miriam Rubio
2020-08-29 19:31 ` Junio C Hamano
2020-08-31 10:50 ` Miriam R.
2020-08-31 17:09 ` Junio C Hamano
2020-08-28 12:46 ` [PATCH v6 07/13] bisect--helper: finish porting `bisect_start()` to C Miriam Rubio
2020-08-28 12:46 ` [PATCH v6 08/13] bisect--helper: retire `--bisect-clean-state` subcommand Miriam Rubio
2020-08-28 12:46 ` [PATCH v6 09/13] bisect--helper: retire `--next-all` subcommand Miriam Rubio
2020-08-28 12:46 ` [PATCH v6 10/13] bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in C Miriam Rubio
2020-08-28 12:46 ` [PATCH v6 11/13] bisect--helper: retire `--check-expected-revs` subcommand Miriam Rubio
2020-08-28 12:46 ` [PATCH v6 12/13] bisect--helper: retire `--write-terms` subcommand Miriam Rubio
2020-08-28 12:46 ` [PATCH v6 13/13] bisect--helper: retire `--bisect-autostart` subcommand Miriam Rubio
2020-08-29 19:31 ` [PATCH v6 00/13] Finish converting git bisect to C part 2 Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828124617.60618-3-mirucam@gmail.com \
--to=mirucam@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).