git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Drew DeVault <sir@cmpwn.com>, git@vger.kernel.org
Subject: Re: [PATCH] send-email: do not prompt for In-Reply-To
Date: Thu, 27 Aug 2020 15:02:49 -0700	[thread overview]
Message-ID: <20200827220249.GA71190@Carlos-MBP> (raw)
In-Reply-To: <xmqqtuwnq3x1.fsf@gitster.c.googlers.com>

On Thu, Aug 27, 2020 at 12:34:02PM -0700, Junio C Hamano wrote:
> 
> That feels both understandable and bogus at the same time.  To:
> is pretty much required (yes, you can use cc: and bcc: without any
> address on To:, but that is not something you'd usually do to send
> patches to mailing lists), so lack of it means either asking
> interactively or aborting.  But other things like in-reply-to are
> optional, and tying the decision to prompt for them or not does not
> feel OK.

but trying to "fix" this breaks 10 year old tests, so it is obvious
that everyone already expects it to work this way (probably hidden
by the fact most people don't let git-send-email prompt for "To:")

the patch after the scissors attempts to document the current "Legacy"
behaviour which should be worth doing regardless of what is done with
this patch.

but I suspect it might be worth adding a new configuration flag like
the one that was propossed so that the prompting could be set per
repository to either "Always" (for when forgetting it will break the
threads in lists that care, like this one) and "Never" (for when the
lists explicitally ask mails to be send without one, because they
use patchew or equivalent (ex: qemu-devel[1])).

Carlo

[1] https://wiki.qemu.org/Contribute/SubmitAPatch
--- >8 ---
Subject: [PATCH] send-email: document logic for In-Reply-To prompting

Eventhough there doesn't seem to be a good reason for it, it is
the way it has been implemented for the last 10 years.

Document the current behaviour (which the tests also depend on)
before it can be tweaked by a future per repository setting.

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 Documentation/git-send-email.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 0a69810147..8e9ebb3fac 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -108,8 +108,7 @@ illustration below where `[PATCH v2 0/3]` is in reply to `[PATCH 0/2]`:
       [PATCH v2 2/3] New tests
       [PATCH v2 3/3] Implementation
 +
-Only necessary if --compose is also set.  If --compose
-is not set, this will be prompted for.
+If --compose is not set, and there is no known "To:" this will be prompted for.
 
 --subject=<string>::
 	Specify the initial subject of the email thread.
-- 
2.28.0.424.gade71fd49b


  parent reply	other threads:[~2020-08-27 22:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 17:55 [PATCH] send-email: do not prompt for In-Reply-To Drew DeVault
2020-08-27 19:04 ` Junio C Hamano
2020-08-27 19:08   ` Junio C Hamano
2020-08-27 19:14     ` Drew DeVault
2020-08-27 19:20       ` Carlo Marcelo Arenas Belón
2020-08-27 19:23         ` Drew DeVault
2020-08-27 19:32           ` Carlo Marcelo Arenas Belón
2020-08-27 19:34         ` Junio C Hamano
2020-08-27 19:34           ` Drew DeVault
2020-08-27 19:46             ` Carlo Arenas
2020-08-27 22:02           ` Carlo Marcelo Arenas Belón [this message]
2020-08-27 22:57             ` Junio C Hamano
2020-08-27 22:59               ` Drew DeVault
2020-08-27 23:05                 ` Drew DeVault
2020-08-28  1:02                   ` Junio C Hamano
2020-08-28  1:10                     ` Drew DeVault
2020-08-28  1:44                     ` Raymond E. Pasco
2020-08-28  1:56                       ` Drew DeVault
2020-08-27 23:23                 ` Junio C Hamano
2020-08-27 23:24                   ` Drew DeVault
2020-08-28 18:39               ` Drew DeVault
2020-08-28 20:58                 ` Raymond E. Pasco
2020-08-28 21:00                 ` Junio C Hamano
2020-08-28 21:01                   ` Drew DeVault
2020-08-28 21:33                     ` Junio C Hamano
2020-08-28 21:35                       ` Drew DeVault
2020-08-27 19:21       ` Junio C Hamano
2020-08-27 19:22         ` Drew DeVault
2020-08-27 19:15   ` Drew DeVault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827220249.GA71190@Carlos-MBP \
    --to=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sir@cmpwn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).