mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Shourya Shukla <>
	Shourya Shukla <>,
	Christian Couder <>
Subject: [PATCH v2 1/3] submodule: eliminate unused parameters from print_submodule_summary()
Date: Thu, 27 Aug 2020 23:14:59 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Eliminate the parameters 'missing_{src,dst}' from the
'print_submodule_summary()' function call since they are not used
anywhere in the function.

Reported-by: Jeff King <>
Mentored-by: Christian Couder <>
Mentored-by: Kaartic Sivaraam <>
Signed-off-by: Shourya Shukla <>
 builtin/submodule--helper.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 63ea39025d..b83f840251 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -982,7 +982,6 @@ static char* verify_submodule_committish(const char *sm_path,
 static void print_submodule_summary(struct summary_cb *info, char* errmsg,
 				    int total_commits, const char *displaypath,
 				    const char *src_abbrev, const char *dst_abbrev,
-				    int missing_src, int missing_dst,
 				    struct module_cb *p)
 	if (p->status == 'T') {
@@ -1154,8 +1153,7 @@ static void generate_submodule_summary(struct summary_cb *info,
 	print_submodule_summary(info, errmsg, total_commits,
 				displaypath, src_abbrev,
-				dst_abbrev, missing_src,
-				missing_dst, p);
+				dst_abbrev, p);

  reply	other threads:[~2020-08-27 17:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 17:44 [GSoC][PATCH v2 0/3] submodule: fixup to summary-v3 Shourya Shukla
2020-08-27 17:44 ` Shourya Shukla [this message]
2020-08-27 17:45 ` [PATCH v2 2/3] submodule: fix style in function definition Shourya Shukla
2020-08-27 17:45 ` [PATCH v2 3/3] t7421: eliminate 'grep' check in t7421.4 for mingw compatibility Shourya Shukla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).