From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 70B6C1F66E for ; Thu, 27 Aug 2020 08:31:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726395AbgH0IbC (ORCPT ); Thu, 27 Aug 2020 04:31:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727999AbgH0IbA (ORCPT ); Thu, 27 Aug 2020 04:31:00 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C834C061264 for ; Thu, 27 Aug 2020 01:30:59 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id u18so4350185wmc.3 for ; Thu, 27 Aug 2020 01:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=K6U6IwPGouraUiskgezSPqWb3nQvx+MFcaaSJXdtiEc=; b=a4XF5qjGMss0ztALu4OL3/ZKnW+Zg3VUUkIhooCzAmENn3ru1nt/2h0Kc2dT0qn2h8 vj2L536GrVuQCIm65QehexMTUckFNBTxljfRGTc317h3cA334mbprLtbyii/+0EIus9I vzdlXRh+uec6YBPsQzNGyQ7x2j1Ncs/SlmJKI53KB4Mmk3id6VMJkTUzUl8BzMlEGpj8 W37eGI/XoQy4yiVvNxVxUB3Ho3JCKRJWgCJlF4QXAv+w+8xR3U/ceRXnFe4aGnt1j/na SXtQEuPEie1ps9CRkT1nSSxnMkoc9FXz0+U4+JZm/EoxXkWS0/oZ1aIrlEnTMpesoREd VaYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=K6U6IwPGouraUiskgezSPqWb3nQvx+MFcaaSJXdtiEc=; b=VcMXW44PS2UwukuzWWfFjwFmXNNYFH5mH0MQXn8LP1Uss//csjm7wxVZOgMHu7Ix/d 28xR9JXyHYZ6TKK/qPgz3jH32wM3F32zW1FKXhSLUqEFutsxX7KmKz6iNaNYmVFQwvYJ YEqBuE67Fyka4f2VCb26hLI8BDaJbAMgKA58OdqEdSTI3Dwa1LDl64MuXPc2dW3RjcYG LKxzkKCZuBDI9zjwFiSwQQU0UFcR99iE4u2rFmSK2htXB8MDpzkcNqIWNx6nW+7zga2h bD8IVbhZ2/fUQFDD4UC85YJhvD2mpCpQ5nRXX4YiUpRErRAvhyF1OR/aT+Xa3sEbBwX0 9wqw== X-Gm-Message-State: AOAM531AgpksaLUI9jaL23FFSetgWKYRlhPMTqcDXqhOfMObwygPcBXH xkeodR5K0yzxN7h5m0jwTZg= X-Google-Smtp-Source: ABdhPJw+3Gjg422mMUTSZAEl5Ec7kD/GL8laK0EqHaxLCKr5FLP4vFhVF/cNNJQ0LCP/bGipMRFLlQ== X-Received: by 2002:a1c:e0d7:: with SMTP id x206mr11638946wmg.91.1598517058157; Thu, 27 Aug 2020 01:30:58 -0700 (PDT) Received: from szeder.dev (78-131-17-40.pool.digikabel.hu. [78.131.17.40]) by smtp.gmail.com with ESMTPSA id n205sm3959776wma.47.2020.08.27.01.30.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Aug 2020 01:30:57 -0700 (PDT) Date: Thu, 27 Aug 2020 10:30:54 +0200 From: SZEDER =?utf-8?B?R8OhYm9y?= To: Johannes Schindelin Cc: Junio C Hamano , Johannes Schindelin via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH v2 3/3] ci: stop linking built-ins to the dashed versions Message-ID: <20200827083054.GD25052@szeder.dev> References: <20200825134714.GC25052@szeder.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Aug 26, 2020 at 06:19:52AM +0200, Johannes Schindelin wrote: > Hi, > > On Tue, 25 Aug 2020, Junio C Hamano wrote: > > > SZEDER Gábor writes: > > > > > I'm afraid I don't understand this patch or the previous one (or > > > both?). So this new Makefile knob stops hard-linking the dashed > > > builtins _during 'make install'_, but it doesn't affect how Git is > > > built by the default target. And our CI jobs only build Git by the > > > default target, but don't run 'make install', so setting > > > SKIP_DASHED_BUILT_INS wouldn't have any affect anyway. > > > > Very very true. Let's drop 3/3 if it is not testing anything new. > > > > I do understand the concern 2/3 wants to address, and it would be a > > real one to you especially if you come from Windows. People on the > > platform wouldn't be able to use shell scripts written in 12 years > > ago or written with the promise we made to our users 12 years ago, > > and unlike hardlink-capable platforms it incurs real cost to install > > these individual binaries on disk. > > Actually, `SKIP_DASHED_BUILT_INS` does not _only_ have an impact on `make > install`: > > $ rm git-add.exe && make > BUILTIN git-add.exe > BUILTIN all > SUBDIR git-gui > SUBDIR gitk-git > SUBDIR templates > > $ rm git-add.exe && make SKIP_DASHED_BUILT_INS=1 > BUILTIN all > SUBDIR git-gui > SUBDIR gitk-git > SUBDIR templates > > See how `git-add.exe` is linked in the first, but not in the second run? Ah, ok, so I did indeed misunderstand the previous patch. Thanks.