From: Lukas Straub <email@example.com> To: Jeff King <firstname.lastname@example.org> Cc: Junio C Hamano <email@example.com>, "Randall S. Becker" <firstname.lastname@example.org>, 'git' <email@example.com>, 'Elijah Newren' <firstname.lastname@example.org>, 'Brandon Williams' <email@example.com>, 'Johannes Schindelin' <Johannes.Schindelin@gmx.de> Subject: Re: [RFC PATCH 0/2] Allow adding .git files and directories Date: Thu, 20 Aug 2020 14:37:55 +0200 [thread overview] Message-ID: <20200820143755.06d39a05@luklap> (raw) In-Reply-To: <20200819201736.GA2511157@coredump.intra.peff.net> [-- Attachment #1: Type: text/plain, Size: 2156 bytes --] On Wed, 19 Aug 2020 16:17:36 -0400 Jeff King <firstname.lastname@example.org> wrote: > On Wed, Aug 19, 2020 at 12:09:11PM -0700, Junio C Hamano wrote: > > > "Randall S. Becker" <email@example.com> writes: > > > > > Just putting my CSIO hat on here. We would need a system-wide setting to > > > prohibit users from using this capability. > > > > Or just discard this patch, which is a lot simpler. I don't see any > > need for this one. > > Yes. Configurability is a lot more complicated than you might think. > Because it's not just system-wide, but _ecosystem_ wide. > > Right now git-fsck complains about ".git" appearing in a tree, and that > check blocks people from pushing such trees to any hosting sites that > enable transfer.fsckObjects (which includes hosters like GitHub). So > you'd not only need to allow the behavior to be loosened for all of the > people using the feature, but you'd need to convince server-side hosters > to loosen their config. And because part of the purpose is to protect > downstream clients from attacks, I doubt that public hosters like GitHub > would do so. I guess they can add a checkbox to their (secured) web-ui to configure this. > It _could_ still be useful in a more isolated environment (e.g., your > company server that is serving only internal repos to employees). But I > have misgivings about a feature that lets people intentionally create > repositories whose history cannot ever interact with other users who > haven't set a special config flag. It's one thing to say "to take > advantage of this feature, we must all agree to have version X, or set > flag Y". But it's another to bake that restriction into the repository > history for all time. Good point. I don't know how we can resolve this, so I will add warning about this (and the security concerns) to the config docs. In the worst-case where the hosting sites don't adopt this config, the user enables and uses this feature despite the warnings and then wants to use a hosting site, he can still rewrite the history. Not nice, but no disaster either. Regards, Lukas Straub > > -Peff [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-20 12:39 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-19 16:43 Lukas Straub 2020-08-19 16:43 ` [RFC PATCH 1/2] dir/read-cache: " Lukas Straub 2020-08-19 16:43 ` [RFC PATCH 2/2] dir: Recurse into nested git repos if they aren't submodules Lukas Straub 2020-08-19 18:03 ` [RFC PATCH 0/2] Allow adding .git files and directories Junio C Hamano 2020-08-19 18:47 ` Randall S. Becker 2020-08-19 19:09 ` Junio C Hamano 2020-08-19 19:23 ` Randall S. Becker 2020-08-19 20:17 ` Jeff King 2020-08-19 20:32 ` Junio C Hamano 2020-08-19 20:38 ` Jeff King 2020-08-19 21:56 ` Randall S. Becker 2020-08-20 10:16 ` Johannes Schindelin 2020-08-20 11:34 ` Lukas Straub 2020-08-20 13:01 ` Jeff King 2020-08-21 12:39 ` Lukas Straub 2020-08-21 13:11 ` Randall S. Becker 2020-08-21 22:52 ` brian m. carlson 2020-08-22 14:21 ` Lukas Straub 2020-08-22 18:53 ` brian m. carlson 2020-08-22 19:12 ` Lukas Straub 2020-08-24 13:52 ` Johannes Schindelin 2020-08-20 12:37 ` Lukas Straub [this message] 2020-08-20 13:08 ` Jeff King 2020-08-19 19:22 ` Lukas Straub 2020-08-19 18:47 ` Lukas Straub 2020-08-19 19:16 ` Randall S. Becker 2020-08-20 11:46 ` Lukas Straub
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200820143755.06d39a05@luklap \ --firstname.lastname@example.org \ --cc=Johannes.Schindelin@gmx.de \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [RFC PATCH 0/2] Allow adding .git files and directories' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).