From: Jonathan Tan <jonathantanmy@google.com>
To: sunshine@sunshineco.com
Cc: jonathantanmy@google.com, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2 3/3] fetch-pack: make packfile URIs work with transfer.fsckobjects
Date: Mon, 17 Aug 2020 13:22:36 -0700 [thread overview]
Message-ID: <20200817202236.1703961-1-jonathantanmy@google.com> (raw)
In-Reply-To: <CAPig+cTv4JiLt+hCSy_RqmwUwu5btTjac6+cFH=ztWeHQgHEyw@mail.gmail.com>
> On Mon, Aug 17, 2020 at 3:49 PM Jonathan Tan <jonathantanmy@google.com> wrote:
> > +test_expect_success 'packfile-uri with transfer.fsckobjects fails on bad object' '
> > + P="$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> > + rm -rf "$P" http_child log &&
> > +
> > + git init "$P" &&
> > + git -C "$P" config "uploadpack.allowsidebandall" "true" &&
> > +
> > + cat >bogus-commit <<EOF &&
> > +tree $EMPTY_TREE
> > +author Bugs Bunny 1234567890 +0000
> > +committer Bugs Bunny <bugs@bun.ni> 1234567890 +0000
> > +
> > +This commit object intentionally broken
> > +EOF
>
> The v2 cover letter says that this now uses <<-EOF so the here-doc
> body can be indented, but that doesn't seem to be the case.
Ah, good catch. I forgot to amend my commit. If Junio doesn't do it
locally then I will send out a v3.
prev parent reply other threads:[~2020-08-17 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 19:32 [PATCH] fetch-pack: make packfile URIs work with transfer.fsckobjects Jonathan Tan
2020-08-14 19:59 ` Junio C Hamano
2020-08-17 19:48 ` [PATCH v2 0/3] " Jonathan Tan
2020-08-17 19:48 ` [PATCH v2 1/3] (various): document from_promisor parameter Jonathan Tan
2020-08-17 19:48 ` [PATCH v2 2/3] fetch-pack: document only_packfile in get_pack() Jonathan Tan
2020-08-17 19:48 ` [PATCH v2 3/3] fetch-pack: make packfile URIs work with transfer.fsckobjects Jonathan Tan
2020-08-17 19:52 ` Eric Sunshine
2020-08-17 20:22 ` Jonathan Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817202236.1703961-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).