From: Emily Shaffer <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: Junio C Hamano <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH 3/5] make git-bugreport a builtin Date: Mon, 17 Aug 2020 05:12:39 -0700 [thread overview] Message-ID: <20200817121239.GA44309@google.com> (raw) In-Reply-To: <20200815063811.GA628010@coredump.intra.peff.net> On Sat, Aug 15, 2020 at 02:38:11AM -0400, Jeff King wrote: > > On Thu, Aug 13, 2020 at 11:01:23AM -0700, Junio C Hamano wrote: > > > > --- > > > Makefile | 6 +----- > > > builtin.h | 1 + > > > bugreport.c => builtin/bugreport.c | 10 +++------- > > > contrib/buildsystems/CMakeLists.txt | 5 +---- > > > git.c | 1 + > > > 5 files changed, 7 insertions(+), 16 deletions(-) > > > rename bugreport.c => builtin/bugreport.c (96%) > > > > I am on the fence, as bugreport does not seem to be fully completed > > part of the system. The original thinking was that it may soon want > > to grow by linking with platform specific libraries for lower-level > > system characteristic identification, at which time we'd not want to > > have it in builtins and "we can take advantage of builtin niceties" > > will cause us regrets. The only reason that hasn't happened as far > > as I can see is because its development speed is rather slow. > > > > So, I dunno. > > Where do we want to go with this? After the discussion and sleeping on > it, I'm still of the mind that we should generally default things to > being builtins unless there's an immediate need not to do so (like > extra link dependencies). But I don't care _too_ much, so I'd rather > eject this patch and move forward with the rest of the series if it's a > sticking point. Thoughts? Just now catching up. I think it's a fine idea to turn it into a builtin. As stated elsewhere, this means the version reported is more reliable (and saves me work which I had on my list to query 'git version' instead of listing the version when git-bugreport was built). It's true that there is more work to do on bugreport, it's true that that work is moving very slowly, as I had a number of things on my plate even before the world turned upside down :) At the time, Junio seemed inclined to take git-bugreport as a standalone, and I didn't care very much one way or another, so it seemed like a fine way to get the series out of review and into use. As I said then, turning it into a builtin down the road isn't difficult - so I'm happy with the general direction. - Emily > > -Peff
next prev parent reply other threads:[~2020-08-17 12:12 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-13 14:55 [PATCH 0/5] slimming down installed size Jeff King 2020-08-13 14:57 ` [PATCH 1/5] Makefile: drop builtins from MSVC pdb list Jeff King 2020-08-13 15:04 ` Taylor Blau 2020-08-13 15:08 ` Jeff King 2020-08-13 16:37 ` Derrick Stolee 2020-08-13 17:40 ` Jeff King 2020-08-14 14:18 ` Johannes Schindelin 2020-08-14 14:32 ` Jeff King 2020-08-17 4:42 ` Johannes Schindelin 2020-08-17 13:20 ` Jeff Hostetler 2020-08-13 14:58 ` [PATCH 2/5] make credential helpers builtins Jeff King 2020-08-13 15:08 ` Taylor Blau 2020-08-13 15:14 ` Jeff King 2020-08-13 17:55 ` Junio C Hamano 2020-08-13 14:59 ` [PATCH 3/5] make git-bugreport a builtin Jeff King 2020-08-13 17:01 ` Derrick Stolee 2020-08-13 17:38 ` Jeff King 2020-08-13 18:25 ` Junio C Hamano 2020-08-13 18:47 ` Junio C Hamano 2020-08-14 10:13 ` Jeff King 2020-08-14 14:25 ` Johannes Schindelin 2020-08-14 10:05 ` Jeff King 2020-08-13 18:01 ` Junio C Hamano 2020-08-14 14:28 ` Johannes Schindelin 2020-08-15 6:38 ` Jeff King 2020-08-17 12:12 ` Emily Shaffer [this message] 2020-08-17 16:58 ` Junio C Hamano 2020-08-17 21:40 ` Jeff King 2020-08-17 12:16 ` Emily Shaffer 2020-08-13 14:59 ` [PATCH 4/5] make git-fast-import " Jeff King 2020-08-13 15:00 ` [PATCH 5/5] drop vcs-svn experiment Jeff King 2020-08-13 15:11 ` Taylor Blau 2020-08-13 15:18 ` Jeff King 2020-08-14 14:39 ` Johannes Schindelin 2020-08-14 15:11 ` Jeff King 2020-08-13 15:13 ` [PATCH 0/5] slimming down installed size Taylor Blau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200817121239.GA44309@google.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 3/5] make git-bugreport a builtin' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).