* [RFC 0/3] support negative refspecs
@ 2020-08-15 0:28 Jacob Keller
2020-08-15 0:29 ` Jacob Keller
0 siblings, 1 reply; 2+ messages in thread
From: Jacob Keller @ 2020-08-15 0:28 UTC (permalink / raw)
To: git, Jeff King; +Cc: Jacob Keller
From: Jacob Keller <jacob.keller@gmail.com>
This is more or less just a port of what Peff already had published a few
years ago at https://lore.kernel.org/git/20140125013433.GA22336@sigill.intra.peff.net/
I cleaned some things up and made sure the tests pass, but haven't yet added
any new tests.
I think the overal design makes sense: applying positive first and then
negative. This appears to be how negative pathspecs work at least as far as
I could tell with a few trials.
The first two patches are cleanup/fixups that I think could go separately if
everyone agrees. The third is the meat of the idea, and where most of the
work needs to be done.
Jacob Keller (3):
refspec: fix documentation referring to refspec_item
refspec: make sure stack refspec_item variables are zeroed
refspec: add support for negative refspecs
builtin/fetch.c | 3 +++
builtin/remote.c | 1 +
refspec.c | 30 +++++++++++++++++++++++++++++
refspec.h | 29 +++++++++++++++-------------
remote.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++-
remote.h | 9 ++++++++-
transport.c | 1 +
7 files changed, 107 insertions(+), 15 deletions(-)
base-commit: 878e727637ec5815ccb3301eb994a54df95b21b8
--
2.28.0.163.g6104cc2f0b60
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC 0/3] support negative refspecs
2020-08-15 0:28 [RFC 0/3] support negative refspecs Jacob Keller
@ 2020-08-15 0:29 ` Jacob Keller
0 siblings, 0 replies; 2+ messages in thread
From: Jacob Keller @ 2020-08-15 0:29 UTC (permalink / raw)
To: Jacob Keller; +Cc: Git mailing list, Jeff King
On Fri, Aug 14, 2020 at 5:28 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
>
> From: Jacob Keller <jacob.keller@gmail.com>
>
> This is more or less just a port of what Peff already had published a few
> years ago at https://lore.kernel.org/git/20140125013433.GA22336@sigill.intra.peff.net/
>
> I cleaned some things up and made sure the tests pass, but haven't yet added
> any new tests.
>
> I think the overal design makes sense: applying positive first and then
> negative. This appears to be how negative pathspecs work at least as far as
> I could tell with a few trials.
>
> The first two patches are cleanup/fixups that I think could go separately if
> everyone agrees. The third is the meat of the idea, and where most of the
> work needs to be done.
>
> Jacob Keller (3):
> refspec: fix documentation referring to refspec_item
> refspec: make sure stack refspec_item variables are zeroed
> refspec: add support for negative refspecs
>
> builtin/fetch.c | 3 +++
> builtin/remote.c | 1 +
> refspec.c | 30 +++++++++++++++++++++++++++++
> refspec.h | 29 +++++++++++++++-------------
> remote.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++-
> remote.h | 9 ++++++++-
> transport.c | 1 +
> 7 files changed, 107 insertions(+), 15 deletions(-)
>
>
> base-commit: 878e727637ec5815ccb3301eb994a54df95b21b8
> --
> 2.28.0.163.g6104cc2f0b60
>
This probably doesn't have the right reply headers, because I forgot
to send the cover letter along with the patches and realized it after
I hit send. Sorry!
Thanks,
Jake
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-15 21:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-15 0:28 [RFC 0/3] support negative refspecs Jacob Keller
2020-08-15 0:29 ` Jacob Keller
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).