From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Eric Sunshine <sunshine@sunshineco.com>
Subject: [PATCH 0/6] more small leak fixes
Date: Fri, 14 Aug 2020 12:13:28 -0400 [thread overview]
Message-ID: <20200814161328.GA153929@coredump.intra.peff.net> (raw)
Based on the discussion over in [1], I wondered how close we were to
being able to run some test scripts with a leak-checker like LSan not
complaining. The answer is...not close.
I picked t5526 more or less at random (it was the first failure when I
did a parallel "make test") to see what it would take to get it passing.
After much effort...I have t5526.1, the setup test, running clean. :)
There were quite a few false positives, but it did actually uncover some
legitimate leaks. This series fixes those. I did it independently of the
leak-fix in [2], but it would be fine to just lump it all together as
one topic.
[1] https://lore.kernel.org/git/20200813155426.GA896769@coredump.intra.peff.net/
[2] https://lore.kernel.org/git/20200814111049.GA4101811@coredump.intra.peff.net/
The patches are:
[1/6]: submodule--helper: use strbuf_release() to free strbufs
[2/6]: checkout: fix leak of non-existent branch names
[3/6]: config: fix leaks from git_config_get_string_const()
[4/6]: config: drop git_config_get_string_const()
[5/6]: config: fix leak in git_config_get_expiry_in_days()
[6/6]: submodule--helper: fix leak of core.worktree value
Documentation/MyFirstContribution.txt | 4 +--
apply.c | 4 +--
builtin/checkout.c | 4 ++-
builtin/fetch.c | 2 +-
builtin/submodule--helper.c | 16 +++++------
cache.h | 4 +--
checkout.c | 3 +--
config.c | 39 ++++++++++++++++++++++-----
config.h | 12 ++++++---
connect.c | 4 +--
editor.c | 2 +-
environment.c | 4 +--
help.c | 2 +-
protocol.c | 2 +-
submodule.c | 4 +--
t/helper/test-config.c | 2 +-
16 files changed, 69 insertions(+), 39 deletions(-)
-Peff
next reply other threads:[~2020-08-14 16:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 16:13 Jeff King [this message]
2020-08-14 16:14 ` [PATCH 1/6] submodule--helper: use strbuf_release() to free strbufs Jeff King
2020-08-14 16:14 ` [PATCH 2/6] checkout: fix leak of non-existent branch names Jeff King
2020-08-14 16:17 ` [PATCH 3/6] config: fix leaks from git_config_get_string_const() Jeff King
2020-08-14 16:19 ` [PATCH 4/6] config: drop git_config_get_string_const() Jeff King
2020-08-14 20:21 ` Junio C Hamano
2020-08-15 6:34 ` Jeff King
2020-08-17 17:36 ` Junio C Hamano
2020-08-14 16:19 ` [PATCH 5/6] config: fix leak in git_config_get_expiry_in_days() Jeff King
2020-08-14 16:20 ` [PATCH 6/6] submodule--helper: fix leak of core.worktree value Jeff King
2020-08-14 16:25 ` [PATCH 0/6] more small leak fixes Jeff King
2020-08-14 16:27 ` Jeff King
2020-08-17 21:32 ` [PATCH v2 0/7] " Jeff King
2020-08-17 21:33 ` [PATCH v2 1/7] clear_pattern_list(): clear embedded hashmaps Jeff King
2020-08-17 21:33 ` [PATCH v2 2/7] submodule--helper: use strbuf_release() to free strbufs Jeff King
2020-08-17 21:33 ` [PATCH v2 3/7] checkout: fix leak of non-existent branch names Jeff King
2020-08-17 21:33 ` [PATCH v2 4/7] config: fix leaks from git_config_get_string_const() Jeff King
2020-08-17 21:33 ` [PATCH v2 5/7] config: drop git_config_get_string_const() Jeff King
2020-08-17 21:33 ` [PATCH v2 6/7] config: fix leak in git_config_get_expiry_in_days() Jeff King
2020-08-17 21:33 ` [PATCH v2 7/7] submodule--helper: fix leak of core.worktree value Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814161328.GA153929@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).