From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id B545F1F66E for ; Fri, 14 Aug 2020 12:40:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727834AbgHNMkO (ORCPT ); Fri, 14 Aug 2020 08:40:14 -0400 Received: from cloud.peff.net ([104.130.231.41]:58998 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726209AbgHNMkM (ORCPT ); Fri, 14 Aug 2020 08:40:12 -0400 Received: (qmail 31796 invoked by uid 109); 14 Aug 2020 12:40:12 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 14 Aug 2020 12:40:12 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 24801 invoked by uid 111); 14 Aug 2020 12:40:11 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 14 Aug 2020 08:40:11 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 14 Aug 2020 08:40:11 -0400 From: Jeff King To: Johannes Schindelin Cc: Sibi Siddharthan , Junio C Hamano , git@vger.kernel.org Subject: Re: What's cooking in git.git (Aug 2020, #01; Mon, 3) Message-ID: <20200814124011.GA4104592@coredump.intra.peff.net> References: <20200804185057.GA1400256@coredump.intra.peff.net> <20200804192053.GA1400936@coredump.intra.peff.net> <20200812141958.GA32453@coredump.intra.peff.net> <20200812160653.GA42443@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Aug 14, 2020 at 02:08:28PM +0200, Johannes Schindelin wrote: > On Wed, 12 Aug 2020, Jeff King wrote: > > > From my perspective as somebody who does not work on Windows, I wonder > > how much value there is in running vsbuild _and_ Windows CI for average > > developers. I have certainly gotten information from these jobs (e.g., > > when introducing a portability problem, or missing a refactoring spot in > > Windows-only code). But I don't think I've ever gotten information from > > vsbuild that wasn't also in the regular windows build. > > There have not been a _ton_ of these instances, but there have been a > couple: Thanks, that was exactly the kind of data I was interested in. > I cannot find any more instances, so yes, I agree that the > `vs-build`/`vs-test` jobs might not be _all_ that necessary. So maybe we > should do something like this? Let's leave it be for now. The topics I had to adjust due to cmake were ones that I'd had sitting around for a while. So while I hit problems immediately, now that the queue is drained it's not clear to me how often it will come up in practice. > -- snipsnap -- > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index 30425404eb3..2549fff8edd 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -122,7 +122,7 @@ jobs: > path: ${{env.FAILED_TEST_ARTIFACTS}} > vs-build: > needs: ci-config > - if: needs.ci-config.outputs.enabled == 'yes' > + if: (github.repository == 'git/git' || github.repository == 'gitgitgadget/git') && needs.ci-config.outputs.enabled == 'yes' If we do go this route, I'd consider defaulting it to on and just letting people disable it through needs.ci-config.outputs.vsbuild or similar. -Peff