From: Shourya Shukla <shouryashukla.oo@gmail.com> To: shouryashukla.oo@gmail.com Cc: christian.couder@gmail.com, git@vger.kernel.org, gitster@pobox.com, Johannes.Schindelin@gmx.de, kaartic.sivaraam@gmail.com, liu.denton@gmail.com, Christian Couder <chriscool@tuxfamily.org> Subject: [PATCH v2 2/4] t7401: change test_i18ncmp syntax for clarity Date: Thu, 13 Aug 2020 00:57:35 +0530 [thread overview] Message-ID: <20200812192737.13971-3-shouryashukla.oo@gmail.com> (raw) In-Reply-To: <20200812192737.13971-1-shouryashukla.oo@gmail.com> Change the test_i18ncmp syntax from 'test_i18ncmp actual expected' to 'test_i18ncmp expected actual' to align it with the convention followed by other tests in the test script. Mentored-by: Christian Couder <chriscool@tuxfamily.org> Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com> --- t/t7401-submodule-summary.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 8ee78bcb69..53943c9cc9 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -183,7 +183,7 @@ test_expect_success 'typechanged submodule(submodule->blob), --cached' " < Add foo5 EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " test_expect_success 'typechanged submodule(submodule->blob), --files' " @@ -193,7 +193,7 @@ test_expect_success 'typechanged submodule(submodule->blob), --files' " > Add foo5 EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " rm -rf sm1 && @@ -204,7 +204,7 @@ test_expect_success 'typechanged submodule(submodule->blob)' " * sm1 $head4(submodule)->$head5(blob): EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " rm -f sm1 && @@ -217,7 +217,7 @@ test_expect_success 'nonexistent commit' " Warn: sm1 doesn't contain commit $head4_full EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " commit_file @@ -285,7 +285,7 @@ EOF test_expect_success '--for-status' " git submodule summary --for-status HEAD^ >actual && - test_i18ncmp actual - <<EOF + test_i18ncmp - actual <<-EOF * sm1 $head6...0000000: * sm2 0000000...$head7 (2): -- 2.28.0
next prev parent reply other threads:[~2020-08-12 19:28 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-05 17:49 [GSoC][RESEND][PATCH 0/4] t7401: modernize, cleanup and warn Shourya Shukla 2020-08-05 17:49 ` [PATCH 1/4] t7401: modernize style Shourya Shukla 2020-08-05 19:37 ` Denton Liu 2020-08-05 20:49 ` Taylor Blau 2020-08-06 8:45 ` Shourya Shukla 2020-08-05 17:49 ` [PATCH 2/4] t7401: change test_i18ncmp syntax for clarity Shourya Shukla 2020-08-05 20:58 ` Taylor Blau 2020-08-05 21:23 ` Junio C Hamano 2020-08-05 17:49 ` [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test Shourya Shukla 2020-08-05 21:01 ` Taylor Blau 2020-08-05 22:25 ` Junio C Hamano 2020-08-05 22:26 ` Taylor Blau 2020-08-05 21:30 ` Junio C Hamano 2020-08-06 8:50 ` Shourya Shukla 2020-08-06 17:18 ` Junio C Hamano 2020-08-05 17:49 ` [PATCH 4/4] t7401: add a WARNING and a NEEDSWORK Shourya Shukla 2020-08-05 21:04 ` Taylor Blau 2020-08-05 21:36 ` Junio C Hamano 2020-08-06 11:27 ` Shourya Shukla 2020-08-06 21:11 ` Junio C Hamano 2020-08-07 14:55 ` Christian Couder 2020-08-12 19:27 ` [GSoC][PATCH v2 0/4] t7401: modernize, cleanup and more Shourya Shukla 2020-08-12 19:27 ` [PATCH v2 1/4] t7401: modernize style Shourya Shukla 2020-08-13 8:06 ` Kaartic Sivaraam 2020-08-13 16:46 ` Junio C Hamano 2020-08-14 14:41 ` Shourya Shukla 2020-08-14 17:06 ` Junio C Hamano 2020-08-12 19:27 ` Shourya Shukla [this message] 2020-08-12 20:57 ` [PATCH v2 2/4] t7401: change test_i18ncmp syntax for clarity Junio C Hamano 2020-08-12 21:02 ` Junio C Hamano 2020-08-14 14:57 ` Shourya Shukla 2020-08-12 19:27 ` [PATCH v2 3/4] t7401: change indentation for enhanced readability Shourya Shukla 2020-08-12 19:27 ` [PATCH v2 4/4] t7401: add a NEEDSWORK Shourya Shukla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200812192737.13971-3-shouryashukla.oo@gmail.com \ --to=shouryashukla.oo@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=chriscool@tuxfamily.org \ --cc=christian.couder@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=kaartic.sivaraam@gmail.com \ --cc=liu.denton@gmail.com \ --subject='Re: [PATCH v2 2/4] t7401: change test_i18ncmp syntax for clarity' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).