From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 6182B1F66E for ; Wed, 12 Aug 2020 16:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726540AbgHLQGz (ORCPT ); Wed, 12 Aug 2020 12:06:55 -0400 Received: from cloud.peff.net ([104.130.231.41]:56516 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726456AbgHLQGy (ORCPT ); Wed, 12 Aug 2020 12:06:54 -0400 Received: (qmail 9961 invoked by uid 109); 12 Aug 2020 16:06:54 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 12 Aug 2020 16:06:54 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 32582 invoked by uid 111); 12 Aug 2020 16:06:53 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 12 Aug 2020 12:06:53 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 12 Aug 2020 12:06:53 -0400 From: Jeff King To: Sibi Siddharthan Cc: Johannes Schindelin , Junio C Hamano , git@vger.kernel.org Subject: Re: What's cooking in git.git (Aug 2020, #01; Mon, 3) Message-ID: <20200812160653.GA42443@coredump.intra.peff.net> References: <20200804185057.GA1400256@coredump.intra.peff.net> <20200804192053.GA1400936@coredump.intra.peff.net> <20200812141958.GA32453@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Aug 12, 2020 at 09:26:05PM +0530, Sibi Siddharthan wrote: > The CMake script was not intended to be a write once and forget > situation, it tries to pull from the Makefile as much > as possible. A few changes are needed, which I intend to do. Yeah, I know. My main beef was that because it fails CI, the urgency of doing that fix gets pushed onto people working on their individual topics (in fact there is nothing for you to fix yet because I haven't even sent these topics upstream). I don't know how to solve that without stopping its use in the vsbuild CI job, though. And clearly we need _something_ to generate the build data for that job. So this may be the last bad thing. >From my perspective as somebody who does not work on Windows, I wonder how much value there is in running vsbuild _and_ Windows CI for average developers. I have certainly gotten information from these jobs (e.g., when introducing a portability problem, or missing a refactoring spot in Windows-only code). But I don't think I've ever gotten information from vsbuild that wasn't also in the regular windows build. -Peff