From: Shourya Shukla <shouryashukla.oo@gmail.com> To: Junio C Hamano <gitster@pobox.com> Cc: git@vger.kernel.org, christian.couder@gmail.com, kaartic.sivaraam@gmail.com, johannes.schindelin@gmx.de, chriscool@tuxfamily.org, liu.denton@gmail.com, me@ttaylorr.com Subject: Re: [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test Date: Thu, 6 Aug 2020 14:20:43 +0530 [thread overview] Message-ID: <20200806085043.GB13942@konoha> (raw) In-Reply-To: <xmqq3650ok53.fsf@gitster.c.googlers.com> On 05/08 02:30, Junio C Hamano wrote: > Shourya Shukla <shouryashukla.oo@gmail.com> writes: > > > The '--for-status' test got its expected output from stdin. This is > > inconsistent with the other tests in the test script which get their > > expected output from a file named 'expected'. > > > > So, change the syntax of the '--for-status' test for uniformity. > > There are a handful examples in t5401 and another one in t3700 that > give the "golden master" from the standard input. When the expected > output is used only once, I do not think it is particularlly bad to > have it this way. So,... meh? I realised what you were trying to say after checking out t5400 and t3700. I understand that this change may not be immediately needed but I think it does make reading the diff a bit easier since having a '-' as a file name does get a bit confusing when reading the output. If a separeate commit just for this change is a problem then I can squash this with the previous commit? What do you think? > Unless there is a compelling reason to insist both are files > (that may make it easier to enhance test_cmp in a certain way > you plan to, for example), that is. > > > Mentored-by: Christian Couder <chriscool@tuxfamily.org> > > Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> > > Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com> > > --- > > t/t7401-submodule-summary.sh | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh > > index 18fefdb0ba..145914cd5a 100755 > > --- a/t/t7401-submodule-summary.sh > > +++ b/t/t7401-submodule-summary.sh > > @@ -285,13 +285,14 @@ EOF > > > > test_expect_success '--for-status' " > > git submodule summary --for-status HEAD^ >actual && > > - test_i18ncmp actual - <<EOF > > + cat >expected <<-EOF && > > * sm1 $head6...0000000: > > > > * sm2 0000000...$head7 (2): > > > Add foo9 > > > > EOF > > + test_i18ncmp expected actual > > " > > > > test_expect_success 'fail when using --files together with --cached' "
next prev parent reply other threads:[~2020-08-06 8:50 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-05 17:49 [GSoC][RESEND][PATCH 0/4] t7401: modernize, cleanup and warn Shourya Shukla 2020-08-05 17:49 ` [PATCH 1/4] t7401: modernize style Shourya Shukla 2020-08-05 19:37 ` Denton Liu 2020-08-05 20:49 ` Taylor Blau 2020-08-06 8:45 ` Shourya Shukla 2020-08-05 17:49 ` [PATCH 2/4] t7401: change test_i18ncmp syntax for clarity Shourya Shukla 2020-08-05 20:58 ` Taylor Blau 2020-08-05 21:23 ` Junio C Hamano 2020-08-05 17:49 ` [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test Shourya Shukla 2020-08-05 21:01 ` Taylor Blau 2020-08-05 22:25 ` Junio C Hamano 2020-08-05 22:26 ` Taylor Blau 2020-08-05 21:30 ` Junio C Hamano 2020-08-06 8:50 ` Shourya Shukla [this message] 2020-08-06 17:18 ` Junio C Hamano 2020-08-05 17:49 ` [PATCH 4/4] t7401: add a WARNING and a NEEDSWORK Shourya Shukla 2020-08-05 21:04 ` Taylor Blau 2020-08-05 21:36 ` Junio C Hamano 2020-08-06 11:27 ` Shourya Shukla 2020-08-06 21:11 ` Junio C Hamano 2020-08-07 14:55 ` Christian Couder 2020-08-12 19:27 ` [GSoC][PATCH v2 0/4] t7401: modernize, cleanup and more Shourya Shukla 2020-08-12 19:27 ` [PATCH v2 1/4] t7401: modernize style Shourya Shukla 2020-08-13 8:06 ` Kaartic Sivaraam 2020-08-13 16:46 ` Junio C Hamano 2020-08-14 14:41 ` Shourya Shukla 2020-08-14 17:06 ` Junio C Hamano 2020-08-12 19:27 ` [PATCH v2 2/4] t7401: change test_i18ncmp syntax for clarity Shourya Shukla 2020-08-12 20:57 ` Junio C Hamano 2020-08-12 21:02 ` Junio C Hamano 2020-08-14 14:57 ` Shourya Shukla 2020-08-12 19:27 ` [PATCH v2 3/4] t7401: change indentation for enhanced readability Shourya Shukla 2020-08-12 19:27 ` [PATCH v2 4/4] t7401: add a NEEDSWORK Shourya Shukla -- strict thread matches above, loose matches on Subject: below -- 2020-07-26 14:25 [GSoC][PATCH 0/4] t7401: modernize, cleanup and warn Shourya Shukla 2020-07-26 14:25 ` [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test Shourya Shukla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200806085043.GB13942@konoha \ --to=shouryashukla.oo@gmail.com \ --cc=chriscool@tuxfamily.org \ --cc=christian.couder@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=johannes.schindelin@gmx.de \ --cc=kaartic.sivaraam@gmail.com \ --cc=liu.denton@gmail.com \ --cc=me@ttaylorr.com \ --subject='Re: [PATCH 3/4] t7401: ensure uniformity in the '\''--for-status'\'' test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).