From: Taylor Blau <me@ttaylorr.com> To: Shourya Shukla <shouryashukla.oo@gmail.com> Cc: git@vger.kernel.org, gitster@pobox.com, christian.couder@gmail.com, kaartic.sivaraam@gmail.com, johannes.schindelin@gmx.de, liu.denton@gmail.com, Christian Couder <chriscool@tuxfamily.org> Subject: Re: [PATCH 4/4] t7401: add a WARNING and a NEEDSWORK Date: Wed, 5 Aug 2020 17:04:08 -0400 [thread overview] Message-ID: <20200805210408.GI9546@syl.lan> (raw) In-Reply-To: <20200805174921.16000-5-shouryashukla.oo@gmail.com> On Wed, Aug 05, 2020 at 11:19:21PM +0530, Shourya Shukla wrote: > Add a WARNING regarding the usage of 'git add' instead of 'git > submodule add' to add submodules to the superproject. Also add a > NEEDSWORK regarding the outdated syntax and working of the test, which > may need to be improved to obtain better and desired results. > > While at it, change the word 'test' to 'test script' in the test > description to avoid ambiguity. > > Mentored-by: Christian Couder <chriscool@tuxfamily.org> > Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> > Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com> > --- > t/t7401-submodule-summary.sh | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh > index 145914cd5a..2db4cf5cbf 100755 > --- a/t/t7401-submodule-summary.sh > +++ b/t/t7401-submodule-summary.sh > @@ -5,8 +5,13 @@ > > test_description='Summary support for submodules > > -This test tries to verify the sanity of summary subcommand of git submodule. > +This test script tries to verify the sanity of summary subcommand of git submodule. > ' > +# WARNING: This test script uses 'git add' instead of 'git submodule add' to add > +# submodules to the superproject. Some submodule subcommands such as init and > +# deinit might not work as expected in this script. > + > +# NEEDSWORK: This test script is old fashioned and may need a big cleanup. It would be worth saying why, especially if you're re-rolling anyway. Even something as simple as: "there are lots of commands taking place outside of a 'test_expect_{success,failure}' block, which is no longer in good-style". I also wouldn't be upset to see some of those fixed up in this series, but I realize that may be a bigger endeavor than you are willing to take on for now. > > . ./test-lib.sh > > -- > 2.27.0 Thanks, Taylor
next prev parent reply other threads:[~2020-08-05 21:04 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-05 17:49 [GSoC][RESEND][PATCH 0/4] t7401: modernize, cleanup and warn Shourya Shukla 2020-08-05 17:49 ` [PATCH 1/4] t7401: modernize style Shourya Shukla 2020-08-05 19:37 ` Denton Liu 2020-08-05 20:49 ` Taylor Blau 2020-08-06 8:45 ` Shourya Shukla 2020-08-05 17:49 ` [PATCH 2/4] t7401: change test_i18ncmp syntax for clarity Shourya Shukla 2020-08-05 20:58 ` Taylor Blau 2020-08-05 21:23 ` Junio C Hamano 2020-08-05 17:49 ` [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test Shourya Shukla 2020-08-05 21:01 ` Taylor Blau 2020-08-05 22:25 ` Junio C Hamano 2020-08-05 22:26 ` Taylor Blau 2020-08-05 21:30 ` Junio C Hamano 2020-08-06 8:50 ` Shourya Shukla 2020-08-06 17:18 ` Junio C Hamano 2020-08-05 17:49 ` [PATCH 4/4] t7401: add a WARNING and a NEEDSWORK Shourya Shukla 2020-08-05 21:04 ` Taylor Blau [this message] 2020-08-05 21:36 ` Junio C Hamano 2020-08-06 11:27 ` Shourya Shukla 2020-08-06 21:11 ` Junio C Hamano 2020-08-07 14:55 ` Christian Couder 2020-08-12 19:27 ` [GSoC][PATCH v2 0/4] t7401: modernize, cleanup and more Shourya Shukla 2020-08-12 19:27 ` [PATCH v2 1/4] t7401: modernize style Shourya Shukla 2020-08-13 8:06 ` Kaartic Sivaraam 2020-08-13 16:46 ` Junio C Hamano 2020-08-14 14:41 ` Shourya Shukla 2020-08-14 17:06 ` Junio C Hamano 2020-08-12 19:27 ` [PATCH v2 2/4] t7401: change test_i18ncmp syntax for clarity Shourya Shukla 2020-08-12 20:57 ` Junio C Hamano 2020-08-12 21:02 ` Junio C Hamano 2020-08-14 14:57 ` Shourya Shukla 2020-08-12 19:27 ` [PATCH v2 3/4] t7401: change indentation for enhanced readability Shourya Shukla 2020-08-12 19:27 ` [PATCH v2 4/4] t7401: add a NEEDSWORK Shourya Shukla -- strict thread matches above, loose matches on Subject: below -- 2020-07-26 14:25 [GSoC][PATCH 0/4] t7401: modernize, cleanup and warn Shourya Shukla 2020-07-26 14:25 ` [PATCH 4/4] t7401: add a WARNING and a NEEDSWORK Shourya Shukla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200805210408.GI9546@syl.lan \ --to=me@ttaylorr.com \ --cc=chriscool@tuxfamily.org \ --cc=christian.couder@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=johannes.schindelin@gmx.de \ --cc=kaartic.sivaraam@gmail.com \ --cc=liu.denton@gmail.com \ --cc=shouryashukla.oo@gmail.com \ --subject='Re: [PATCH 4/4] t7401: add a WARNING and a NEEDSWORK' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).