From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7D6031F990 for ; Wed, 5 Aug 2020 10:04:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727941AbgHEKER (ORCPT ); Wed, 5 Aug 2020 06:04:17 -0400 Received: from cloud.peff.net ([104.130.231.41]:48876 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgHEKDx (ORCPT ); Wed, 5 Aug 2020 06:03:53 -0400 Received: (qmail 11644 invoked by uid 109); 5 Aug 2020 10:03:52 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 05 Aug 2020 10:03:52 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 21434 invoked by uid 111); 5 Aug 2020 10:03:52 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 05 Aug 2020 06:03:52 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 5 Aug 2020 06:03:51 -0400 From: Jeff King To: Martin =?utf-8?B?w4VncmVu?= Cc: Taylor Blau , SZEDER =?utf-8?B?R8OhYm9y?= , Junio C Hamano , Git Mailing List Subject: Re: racy test failure in tb/upload-pack-filters Message-ID: <20200805100351.GA2126375@coredump.intra.peff.net> References: <20200805084240.GA1802257@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Aug 05, 2020 at 11:27:22AM +0200, Martin Ă…gren wrote: > > In theory we'd see both copies of the message in the second case. But > > now always! As soon as the client sees ERR, it exits and we run grep. > > s/now/not/ Oops, thanks. > > - grep "filter '\''blob:none'\'' not supported" err > > + test_i18ngrep "filter '\''blob:none'\'' not supported" err > > Right, this is the one from the intro and the commit message. > > > - grep "tree filter allows max depth 0, but got 1" err > > + test_i18ngrep "tree filter allows max depth 0, but got 1" err > > This one isn't translated, so this hunk could be dropped. Or maybe you > wanted to knowingly cast a slightly wider net? (And this does fit the > subject of your patch.) Neither message is translated in itself, but the bug can happen with either of them (because of the translation of the "remote error" string). The tree-depth one was actually in the first failure I saw, but when I re-ran it to produce output for the commit message, I got one of the other tests. -Peff