From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 516761F990 for ; Tue, 4 Aug 2020 19:21:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727035AbgHDTUz (ORCPT ); Tue, 4 Aug 2020 15:20:55 -0400 Received: from cloud.peff.net ([104.130.231.41]:48006 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbgHDTUy (ORCPT ); Tue, 4 Aug 2020 15:20:54 -0400 Received: (qmail 5357 invoked by uid 109); 4 Aug 2020 19:20:54 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 04 Aug 2020 19:20:54 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 14766 invoked by uid 111); 4 Aug 2020 19:20:53 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 04 Aug 2020 15:20:53 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 4 Aug 2020 15:20:53 -0400 From: Jeff King To: Junio C Hamano Cc: Sibi Siddharthan , git@vger.kernel.org Subject: Re: What's cooking in git.git (Aug 2020, #01; Mon, 3) Message-ID: <20200804192053.GA1400936@coredump.intra.peff.net> References: <20200804185057.GA1400256@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Aug 04, 2020 at 11:58:43AM -0700, Junio C Hamano wrote: > > I ran into issues with this, as I have several in-progress topics (not > > yet sent to the list) that touch our Makefile, and they needed updates > > to the cmake file (because it reproduces a lot of the lists and logic > > from the Makefile). > > > > The original philosophy behind putting it in contrib is that most people > > wouldn't have to care, and folks interested in cmake would be > > responsible for keeping it up to date. But the top patch makes it hard > > to ignore, because the vs-build CI job will fail. > > > > I'm not sure of the right path forward. I was definitely unenthused to > > be dealing with cmake, and the problem came up as soon as the series hit > > next. > > My hope is that if we let vs-build broken long enough, those who > want to see cmake to graduate would fix it. We can always threaten > the topic to be discarded out of 'next' after the next release if it > hasn't been fixed ;-) That was my philosophy, too, but it's annoying in the meantime as I get a notification for "your build is broken" every time I run CI. So it becomes a game of chicken over who gets annoyed first. ;) -Peff