From: Jeff King <peff@peff.net>
To: Matt Rogers <mattr94@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Diff --stat for files that differ only in whitespace
Date: Fri, 31 Jul 2020 15:48:10 -0400 [thread overview]
Message-ID: <20200731194810.GA849395@coredump.intra.peff.net> (raw)
In-Reply-To: <CAOjrSZskJRj+TVV35fEp-Mhd+proVV72rh3vAcVFnNfhRy2ayA@mail.gmail.com>
On Fri, Jul 31, 2020 at 03:26:16PM -0400, Matt Rogers wrote:
> > This seemed familiar, so I dug up some prior discussion here:
> >
> > https://lore.kernel.org/git/1484704915.2096.16.camel@mattmccutchen.net/
> >
> > We didn't come to a resolution there, but there is a patch to play with,
> > and I think nobody was opposed to the notion that with the right
> > code change we could be suppressing these whitespace-only stat lines
> >
> > -Peff
>
>
> I think for now I'm going to feed --numstat into a script like Junio suggested.
> Out of curiosity what would it take to get that patch into git? Is it just a
> matter of someone just verifying it and submitting it?
Yeah, I think it would require making an argument that the patch covers
the correct set of cases (or fixing it if it doesn't), and probably
adding some tests.
-Peff
next prev parent reply other threads:[~2020-07-31 19:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 13:10 Diff --stat for files that differ only in whitespace Matt Rogers
2020-07-31 17:32 ` Junio C Hamano
2020-07-31 17:41 ` Jeff King
2020-07-31 19:26 ` Matt Rogers
2020-07-31 19:48 ` Jeff King [this message]
2020-07-31 20:25 ` Junio C Hamano
2020-07-31 20:43 ` Matt Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731194810.GA849395@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mattr94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).