From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 81FBF1F5AE for ; Fri, 31 Jul 2020 17:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733243AbgGaRps (ORCPT ); Fri, 31 Jul 2020 13:45:48 -0400 Received: from cloud.peff.net ([104.130.231.41]:43872 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729018AbgGaRps (ORCPT ); Fri, 31 Jul 2020 13:45:48 -0400 Received: (qmail 23313 invoked by uid 109); 31 Jul 2020 17:45:48 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 31 Jul 2020 17:45:48 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 28619 invoked by uid 111); 31 Jul 2020 17:45:47 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 31 Jul 2020 13:45:47 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 31 Jul 2020 13:45:47 -0400 From: Jeff King To: Alban Gruin Cc: Christian Couder , git@vger.kernel.org, Junio C Hamano , Christian Couder Subject: Re: [PATCH v5 3/3] ref-filter: add support for %(contents:size) Message-ID: <20200731174547.GC843002@coredump.intra.peff.net> References: <20200710164739.6616-1-chriscool@tuxfamily.org> <20200716121940.21041-1-chriscool@tuxfamily.org> <20200716121940.21041-4-chriscool@tuxfamily.org> <21bb2dad-5845-8cee-8f6a-1089ef7cae3b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <21bb2dad-5845-8cee-8f6a-1089ef7cae3b@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jul 31, 2020 at 07:37:22PM +0200, Alban Gruin wrote: > > + # Leave $expect unquoted to lose possible leading whitespaces > > + echo $expect >expected > > + test_expect_${4:-sucess} $PREREQ "basic atom: $1 contents:size" ' > > There is a typo here, and $expect is written to `expected', but > `test_cmp' wants `expect'. Fixing those mistakes does not reveal any > broken tests. I thought at first you meant that the typo was s/expected/expect, and wondered how this could possibly have passed. But the typo is s/sucess/success/, so we were in fact not running the test at all (and were generating "test_expect_sucess: not found" messages to stderr, but outside of any test block. Yikes. Thanks for spotting. -Peff