From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 33C3F1F5AE for ; Tue, 28 Jul 2020 16:04:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731286AbgG1QDa (ORCPT ); Tue, 28 Jul 2020 12:03:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731044AbgG1QD3 (ORCPT ); Tue, 28 Jul 2020 12:03:29 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70B03C061794 for ; Tue, 28 Jul 2020 09:03:29 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id v22so9289718qtq.8 for ; Tue, 28 Jul 2020 09:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=snfJRMgcBXV5my//AWoJiGdGh/AJTuRaJnm6moZ2Zk4=; b=dw3ZMMC9xIRgvvgcFZtMiOpQubMzz7zpk4SQG+TI8v5UOekbkk0pllOHjFLcL5CaZ0 ixpBkZqLcrod7M28hLzH4XdbV3qPHsEWkpdPQ3cABPOkg7XNqpsEBva/WJzXu1wj8d5c ofqAuRWLak6jy/xqRJVTR1ODNtFahSPbYy3gFiOVXGsxPDWzi9OQ4YUuP6IW6GTaUuKS UJm4B2HPM+DyRGc/u2haWEEkUV+crU6eaSHSXc3O0TpGLlPJEiXNWjdHFrK5ptx3luRJ MeYmVPZpfQjCOQFpdwMrzDD91UJZ3s5+T8TWE+6GEc+1z9ZYw2Mt3LE0mreOl2ieFc4Z /Hxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=snfJRMgcBXV5my//AWoJiGdGh/AJTuRaJnm6moZ2Zk4=; b=HE2QSZCKH4x+VOLm9ru/ubyl/k163C8WKorFt/NAM6JD2pLlhX5SpuECyHm1pOarVG iW85+is/qLm8MOzbmPXm6jo6g2N3orPmM+RU1qb5n5ovynlYqv/T06JASMBjCaWkNnly u74auISArLo/QKyW33Y9Z9vX3RuL1imlAVig6VakjyX/OH/nOneOvpajbVEdP7eowNX7 VvHldlDmX7m9ou8MJ1t2SSeBk5lrF063osLiQDa2BBEdTE7ckjoWSRRvjl0ar9KPlYEm XX5yTVYnzhUSfWr3fL6DpqMxh4U9cDgPjF7OqVNDK6AhQHp87kSXmnQ5NJsCVKyUyiPC 6MRw== X-Gm-Message-State: AOAM531rGxevfl3whMfAyCrXeHQhWuvhv/3HnPATDegejeAMGD/innCp ALh2Ol7opR66OiQ66i2y4+X1ug== X-Google-Smtp-Source: ABdhPJyE5y3YVJtlEuh1wL1dkhmUKh6Hv3+arGXDbXK39wT4RtFdlLAPEnX4OY7+1mZQ7fPmuBlE7A== X-Received: by 2002:ac8:188:: with SMTP id x8mr6481873qtf.372.1595952208521; Tue, 28 Jul 2020 09:03:28 -0700 (PDT) Received: from localhost ([2605:9480:22e:ff10:9c58:8530:481a:f835]) by smtp.gmail.com with ESMTPSA id e15sm12914974qtw.22.2020.07.28.09.03.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2020 09:03:27 -0700 (PDT) Date: Tue, 28 Jul 2020 12:03:26 -0400 From: Taylor Blau To: Abhishek Kumar via GitGitGadget Cc: git@vger.kernel.org, Derrick Stolee , Jakub =?utf-8?B?TmFyxJlic2tp?= , Abhishek Kumar Subject: Re: [PATCH 4/6] commit-graph: consolidate compare_commits_by_gen Message-ID: <20200728160326.GE87373@syl.lan> References: <812fe75fc7252db0b7b6604f84b17dcf7324b922.1595927632.git.gitgitgadget@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <812fe75fc7252db0b7b6604f84b17dcf7324b922.1595927632.git.gitgitgadget@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jul 28, 2020 at 09:13:49AM +0000, Abhishek Kumar via GitGitGadget wrote: > From: Abhishek Kumar > > Comparing commits by generation has been independently defined twice, in > commit-reach and commit. Let's simplify the implementation by moving > compare_commits_by_gen() to commit-graph. > > Signed-off-by: Abhishek Kumar > --- > commit-graph.c | 15 +++++++++++++++ > commit-graph.h | 2 ++ > commit-reach.c | 15 --------------- > commit.c | 9 +++------ > 4 files changed, 20 insertions(+), 21 deletions(-) All looks good to me. Reviewed-by: Taylor Blau Thanks, Taylor