On 2020-07-26 at 23:34:23, Eric Sunshine wrote: > Not necessarily worth a re-roll, but this error message could be more > helpful by providing additional context: > > return error("invalid value for extensions.objectFormat: %s", value); > > Notice I also capitalized "Format" since this is a user-facing message. > > Also, should this message be localizable _(...)? This message is actually going away and Junio's merge into seen removes it entirely in favor of Peff's solution. So I'm going to leave it as it is to improve conflict resolution since it won't live much longer than this specific series, and may not even live that long depending on the release and when Peff's series gets merged in. -- brian m. carlson: Houston, Texas, US