From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 462A51F5AE for ; Fri, 24 Jul 2020 19:51:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbgGXTv1 (ORCPT ); Fri, 24 Jul 2020 15:51:27 -0400 Received: from cloud.peff.net ([104.130.231.41]:37496 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbgGXTv1 (ORCPT ); Fri, 24 Jul 2020 15:51:27 -0400 Received: (qmail 24794 invoked by uid 109); 24 Jul 2020 19:51:27 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 24 Jul 2020 19:51:27 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 26133 invoked by uid 111); 24 Jul 2020 19:51:26 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 24 Jul 2020 15:51:26 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 24 Jul 2020 15:51:26 -0400 From: Jeff King To: Taylor Blau Cc: SZEDER =?utf-8?B?R8OhYm9y?= , git@vger.kernel.org, chriscool@tuxfamily.org, gitster@pobox.com Subject: Re: [PATCH v2 0/4] upload-pack: custom allowed object filters Message-ID: <20200724195126.GB4013174@coredump.intra.peff.net> References: <20200723204325.GM11341@szeder.dev> <20200724165133.GA15287@syl.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200724165133.GA15287@syl.lan> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jul 24, 2020 at 12:51:33PM -0400, Taylor Blau wrote: > Let me double check my understanding... I think that you are suggesting > the following three things: > > - Write the same message as an err packet over the wire as we do when > 'die()'ing from inside of upload-pack.c > > - Don't mark said message(s) for translation, matching what we do in > the rest of upload-pack.c. > > - Re-introduce the 'test_must_fail ok=sigpipe' and stop grepping > stderr for the right message. > > Do I have that right? I'm not Gábor, but that is the sequence I think is best. Between the die() and the ERR, the ERR packets are way more useful in practice, since they actually go back to the client. I'd even suggest we do away with the die() messages entirely (since they're either redundant or go nowhere, depending on the protocol), but I think it would make sense to wait until the raciness issues are fixed (until then, they _might_ help in the redundant cases, which is what the test here is relying on). -Peff