git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: starlord via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Jiang Xin <zhiyou.jx@alibaba-inc.com>,
	starlord <bojun.cbj@gmail.com>,
	Bojun Chen <bojun.cbj@alibaba-inc.com>
Subject: Re: [PATCH] githooks.txt: use correct "reference-transaction" hook name
Date: Fri, 24 Jul 2020 16:21:56 +0200	[thread overview]
Message-ID: <20200724142156.GB1032@xps.pks.im> (raw)
In-Reply-To: <pull.681.git.1595599077623.gitgitgadget@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

Hi Bojun,

On Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote:
> From: Bojun Chen <bojun.cbj@alibaba-inc.com>
> 
> The "reference transaction" hook was introduced in commit 6754159767
> (refs: implement reference transaction hook, 2020-06-19). The name of
> the hook is declared as "reference-transaction" in "refs.c" and
> testcases, but the name declared in "githooks.txt" is different.
> 
> Signed-off-by: Bojun Chen <bojun.cbj@alibaba-inc.com>

Indeed, thanks for catching this!

Reviewed-by: Patrick Steinhardt <ps@pks.im>

Patrick

> ---
>     githooks.txt: use correct "reference-transaction" hook name
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FBerger7%2Fmaster-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger7/master-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/681
> 
>  Documentation/githooks.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
> index 642471109f..31b601e4bc 100644
> --- a/Documentation/githooks.txt
> +++ b/Documentation/githooks.txt
> @@ -404,8 +404,8 @@ Both standard output and standard error output are forwarded to
>  `git send-pack` on the other end, so you can simply `echo` messages
>  for the user.
>  
> -ref-transaction
> -~~~~~~~~~~~~~~~
> +reference-transaction
> +~~~~~~~~~~~~~~~~~~~~~
>  
>  This hook is invoked by any Git command that performs reference
>  updates. It executes whenever a reference transaction is prepared,
> 
> base-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda
> -- 
> gitgitgadget

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-07-24 14:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 13:57 starlord via GitGitGadget
2020-07-24 14:21 ` Patrick Steinhardt [this message]
2020-07-24 20:54   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724142156.GB1032@xps.pks.im \
    --to=ps@pks.im \
    --cc=bojun.cbj@alibaba-inc.com \
    --cc=bojun.cbj@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=zhiyou.jx@alibaba-inc.com \
    --subject='Re: [PATCH] githooks.txt: use correct "reference-transaction" hook name' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).