From: Jeff King <peff@peff.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: git@vger.kernel.org, bup-list@googlegroups.com,
Jamie Wyrick <terrifiedquack80@gmail.com>
Subject: Re: [PATCH v3] pack-write/docs: update regarding pack naming
Date: Thu, 23 Jul 2020 14:32:47 -0400 [thread overview]
Message-ID: <20200723183247.GD3975154@coredump.intra.peff.net> (raw)
In-Reply-To: <20200722214031.116161-1-johannes@sipsolutions.net>
On Wed, Jul 22, 2020 at 11:40:31PM +0200, Johannes Berg wrote:
> The index-pack documentation explicitly states that the pack
> name is derived from the sorted list of object names, but
> since commit 1190a1acf800 ("pack-objects: name pack files
> after trailer hash") that isn't true anymore.
>
> Be less explicit in the docs as to what the exact output is,
> and just say that it's whatever goes into the pack name.
>
> Also update a comment on write_idx_file() since it no longer
> modifies the sha1 variable (it's const now anyway), as noted
> by Junio.
Sorry, I should have fixed these way back in 1190a1acf800. Thanks for
fixing them. :)
-Peff
prev parent reply other threads:[~2020-07-23 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 21:40 [PATCH v3] pack-write/docs: update regarding pack naming Johannes Berg
2020-07-22 23:49 ` Junio C Hamano
2020-07-23 18:32 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723183247.GD3975154@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bup-list@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=terrifiedquack80@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).