* [PATCH] doc: remove misleading documentation on pack names
@ 2020-07-22 20:24 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2020-07-22 20:24 UTC (permalink / raw)
To: git; +Cc: bup-list, Jamie Wyrick
The index-pack documentation explicitly states that the pack
name is derived from the sorted list of object names, but
that clearly isn't true. I can't seem to be able to figure
out if this was ever changed though.
Be less explicit in the docs as to what the exact output is,
and just say that it's whatever goes into the pack name.
Really it seems to be the sha1 of the entire file, without
the checksum footer.
Signed-off-by: Johannes Berg <firstname.lastname@example.org>
It was reported that bup writes pack files that have a name
different from what git does, and I think it's quite possibly
because of this documentation ... it doesn't actually really
*matter* though, as long as the file is internally consistent
nothing checks that the name also matches the footer.
You can also take this as a bug report and fix the language in
some other, perhaps more precise way, if you prefer :-)
Documentation/git-index-pack.txt | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/Documentation/git-index-pack.txt b/Documentation/git-index-pack.txt
index 9316d9a80b0d..ace40fa9f363 100644
@@ -104,12 +104,11 @@ This option cannot be used with --stdin.
-Once the index has been created, the list of object names is sorted
-and the SHA-1 hash of that list is printed to stdout. If --stdin was
-also used then this is prefixed by either "pack\t", or "keep\t" if a
-new .keep file was successfully created. This is useful to remove a
-.keep file used as a lock to prevent the race with 'git repack'
+Once the index has been created, the hash that goes into the name of
+the pack/idx file is printed to stdout. If --stdin was also used then
+this is prefixed by either "pack\t", or "keep\t" if a new .keep file
+was successfully created. This is useful to remove a .keep file used
+as a lock to prevent the race with 'git repack' mentioned above.
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-22 20:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 20:24 [PATCH] doc: remove misleading documentation on pack names Johannes Berg
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).