From: Jonathan Tan <jonathantanmy@google.com>
To: gitster@pobox.com
Cc: jonathantanmy@google.com, git@vger.kernel.org, sluongng@gmail.com
Subject: Re: [PATCH 2/2] pack-objects: prefetch objects to be packed
Date: Tue, 21 Jul 2020 16:37:07 -0700 [thread overview]
Message-ID: <20200721233707.1363438-1-jonathantanmy@google.com> (raw)
In-Reply-To: <xmqqh7u07e41.fsf@gitster.c.googlers.com>
> Junio C Hamano <gitster@pobox.com> writes:
>
> >>> The optimization makes sense to me if certain
> >>> conditions are met, like...
> >>>
> >>> - Most of the time there is no missing object due to promisor, even
> >>> if has_promissor_to_remote() is true;
> >>
> >> I think that optimizing for this condition makes sense - most pushes (I
> >> would think) are pushes of objects we create locally, and thus no
> >> objects are missing.
>
> Another simple thing I missed. Why do we specifically refer to
> "push" here? Is this codepath in pack-objects not used or less
> often used by upload-pack (which is what serves "fetch")?
>
> I just wanted to make sure that we are not optimizing for "push",
> trading efficiency for "fetch" off.
Ah...that's true. For "fetch" I think it's less important because the
multiple roundtrips of the pack negotiation means that the packfiles are
usually more specific, but this optimization will help "fetch" too. I
don't think we're optimizing at the expense of "fetch" - any
improvements should benefit both similarly.
next prev parent reply other threads:[~2020-07-21 23:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 0:21 [PATCH 0/2] Prefetch objects in pack-objects Jonathan Tan
2020-07-21 0:21 ` [PATCH 1/2] pack-objects: refactor to oid_object_info_extended Jonathan Tan
2020-07-21 0:21 ` [PATCH 2/2] pack-objects: prefetch objects to be packed Jonathan Tan
2020-07-21 1:00 ` Junio C Hamano
2020-07-21 16:37 ` Jonathan Tan
2020-07-21 19:23 ` Junio C Hamano
2020-07-21 21:27 ` Junio C Hamano
2020-07-21 23:37 ` Jonathan Tan [this message]
2020-07-21 23:56 ` Junio C Hamano
2020-07-21 23:20 ` Jonathan Tan
2020-07-21 23:51 ` Junio C Hamano
2020-07-22 21:30 ` Jonathan Tan
2020-07-22 21:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721233707.1363438-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sluongng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).