From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 687171F5AE for ; Mon, 20 Jul 2020 17:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730542AbgGTRdi (ORCPT ); Mon, 20 Jul 2020 13:33:38 -0400 Received: from cloud.peff.net ([104.130.231.41]:33538 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726812AbgGTRdi (ORCPT ); Mon, 20 Jul 2020 13:33:38 -0400 Received: (qmail 23513 invoked by uid 109); 20 Jul 2020 17:33:37 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 20 Jul 2020 17:33:37 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 14668 invoked by uid 111); 20 Jul 2020 17:33:37 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 20 Jul 2020 13:33:37 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 20 Jul 2020 13:33:36 -0400 From: Jeff King To: Drew DeVault Cc: "Junio C Hamano" , git@vger.kernel.org Subject: Re: [PATCH v2] git-send-email: die if sendmail.* config is set Message-ID: <20200720173336.GC2045458@coredump.intra.peff.net> References: <20200718202142.111015-1-sir@cmpwn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200718202142.111015-1-sir@cmpwn.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Jul 18, 2020 at 04:21:42PM -0400, Drew DeVault wrote: > I've seen several people mis-configure git send-email on their first > attempt because they set the sendmail.* config options - not > sendemail.*. This patch detects this mistake and bails out with a > friendly warning. This basically claims the "sendmail.*" namespace for send-email. Not strictly, but if we're going to warn about anything set in it, it effectively shuts out other uses. I'm OK with that, but if we're going to do so, should we perhaps just say "sendmail.* is an alias for sendemail.*"? Then rather than getting a warning, this mistake would Just Work. -Peff